Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for syntax #479

Closed
wants to merge 2 commits into from
Closed

support for syntax #479

wants to merge 2 commits into from

Conversation

yihozhang
Copy link
Collaborator

Fixes #455

@yihozhang yihozhang requested a review from a team as a code owner December 5, 2024 03:18
@yihozhang yihozhang requested review from FTRobbin and removed request for a team December 5, 2024 03:18
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 5, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #479 will not alter performance

Comparing yihozhang-for (cee15b6) with main (246b195)

Summary

✅ 8 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main yihozhang-for Change
🆕 for N/A 689.1 µs N/A

saulshanabrook
saulshanabrook reviewed Dec 5, 2024
View reviewed changes
src/ast/mod.rs
@@ -494,6 +494,7 @@ where
ruleset: Symbol,
rule: GenericRule<Head, Leaf>,
},
For(GenericRule<Head, Leaf>),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some docs?

@yihozhang yihozhang mentioned this pull request Jan 5, 2025
Merged
@yihozhang
Copy link
Collaborator Author

Implemented by egraphs-good/egglog-experimental#2

@yihozhang yihozhang closed this Jan 6, 2025
@Alex-Fischman Alex-Fischman deleted the yihozhang-for branch January 6, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulshanabrook saulshanabrook saulshanabrook left review comments

@FTRobbin FTRobbin Awaiting requested review from FTRobbin FTRobbin is a code owner automatically assigned from egraphs-good/egglog-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax proposal: for
2 participants
@yihozhang @saulshanabrook