Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"volare path" ignores --pdk-root argument #93

Closed
dpetrisko opened this issue Jan 1, 2025 · 2 comments
Closed

"volare path" ignores --pdk-root argument #93

dpetrisko opened this issue Jan 1, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@dpetrisko
Copy link

dpetrisko commented Jan 1, 2025

Description

Hello! I came across this issue trying to work around #83 with "volare path" and "volare output" to construct a current PDK path. So you'll see the actual problem is a little silly:

volare path ( points to $HOME/.volare )
volare path --pdk-root=<some pdk root> ( incorrectly points to $HOME/.volare )
PDK_ROOT=<some pdk root> volare path ( correctly points to )

The volare --help command indicates that this should work:

$ volare path --help
Usage: volare path [OPTIONS] [VERSION]

  Prints the path of the volare PDK root.

  If a version is provided over the commandline, it prints the path to this
  version instead.

Options:
  --pdk-root TEXT  Path to the PDK root  [default: /home/petrisko/.volare]
  --pdk TEXT       The PDK family to install  [default: sky130]
  --help           Show this message and exit.

Expected Behavior

volare path --pdk-root=<some pdk root> and PDK_ROOT=<some pdk root> volare path should both point to the same custom PDK root.

Relevant command

$ volare ls --pdk-root=/myhome/.VENV/pdk
$ volare path
$ volare path --pdk-root=/myhome/.VENV/pdk
$ PDK_ROOT=/myhome/.VENV/pdk volare path

Relevant log output

$ volare ls --pdk-root=/myhome/.VENV/pdk
no oauth token found for github.com
In /myhome/.VENV/pdk/volare/sky130/versions:
└── 7519dfb04400f224f140749cda44ee7de6f5e095 (2022.02.10) (enabled)
$ volare path 
/myhome/.volare
$ volare path --pdk-root=/myhome/.VENV/pdk
/myhome/.volare
$ PDK_ROOT=/myhome/.VENV/pdk volare path
/myhome/.VENV/pdk
@donn
Copy link
Member

donn commented Jan 1, 2025

Well, that's weird. Thanks for the report.

@donn donn added the bug Something isn't working label Jan 1, 2025
@donn donn closed this as completed in 50b53e4 Jan 1, 2025
@dpetrisko
Copy link
Author

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants