-
Notifications
You must be signed in to change notification settings - Fork 28
Closed
Description
I'm trying to update an app to [email protected]. I'm getting the error Cannot read property 'sourcemaps' of undefined
from /node_modules/ember-browserify/lib/index.js:21:39
. When I add a console.log(Object.keys(app))
right above that line, I get:
[ 'project',
'name',
'env',
'isProduction',
'registry',
'bowerDirectory',
'tests',
'hinting',
'options',
'vendorFiles',
'_styleOutputFiles',
'_scriptOutputFiles',
'legacyFilesToAppend',
'vendorStaticStyles',
'otherAssetPaths',
'legacyTestFilesToAppend',
'vendorTestStaticStyles',
'trees' ]
[ '_super',
'parent',
'project',
'ui',
'addonPackages',
'addons',
'addonDiscovery',
'addonsFactory',
'registry',
'_didRequiredBuildPackages',
'nodeModulesPath',
'treePaths',
'treeForMethods',
'_addonsInitialized',
'app' ]
So, one of the calls doesn't have the app.options
object. When I add app.options &&
to the line, the upgrade goes otherwise smoothly. I didn't change ember-browserify versions between ember-cli 2.6.3 and 2.7.0. It may be that there is a bug in ember-cli that should be sending you the options hash and isn't.
Metadata
Metadata
Assignees
Labels
No labels