-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trajectories vulnerable to forthcoming changes in sp and rgdal #25
Comments
Thanks. I tried to reproduce these warnings (and error) in a docker container running GDAL 3.0.2 and PROJ 6.2.1 and rgdal 1.5-2. I don't see the warnings you got, but get several of this kind:
Was that to be expected?
|
The waarnings, yes certainly - they seem to come from pre-cooked objects (say from Could you destill the voluminous details to see whether you find the error I found? I cannot confirm that you are using my fork sp 1.3-3 - install R-Forge rgdal first, then my github fork sp which requires rgdal >= 1.5-1? |
Thanks! With the sp fork, I get a clean check:
|
This is after correcting the error I found, right? Or can you not reproduce the error? If not, a change I made last night to accommodate plotKML may have cut in. |
This was with fresh (Today) installs from github (sp) and r-forge (rgdal). |
But had you changed the affected package from the CRAN release? Can you reproduce the error I found (non-identical crs strings - I guess 6.2.0 inserts +no_defs:
|
I checked the CRAN release. No errors here, but I can reproduce the ones you report at r-spatial/gstat#56. |
No taxidata anywhere. Re-running on my work machine by ssh, still ill at home. Error in tests still present. Further LaTeX errors (extra non-basic LaTeX packages missing). Error in:
Go to tests/track.R, do until
What is difficult here? Re-do after re-installing rgdal with Tom's mess from yesterday:
If you are running this on the correct basis, you cannot pass the test, because:
that is,
Which of:
or
is TRUE for you? The test in trajectories can only pass if both are TRUE, I think, and your declared setting should send the PROJ string to |
It was something else, but I found the problem now. |
I'm not sure that it is easy to check for equality without pushing the test string out through the same runtime normalisation procedure, something like:
which then uses the runtime CRS in play (old and new should both work) - that is do not test just string values without passing them through the constructor (same for |
This also works:
|
* replace all +ellps= with +datum= * drop literal proj4string checking test
Looks like renaming all |
Won't this only work for I agree that we need to skip literal proj4string identicals.I don't yet see a clear path to testing equality. |
with GDAL 3.0.4 and PROJ 6.3.0 |
Current github master resolves error. |
Running revdep checks for current rgdal on R-Forge - see:
https://stat.ethz.ch/pipermail/r-sig-geo/2019-November/027801.html
shows the errors in the attached test log, related to use of PROJ&/GDAL3
and required changes to sp and rgdal. If useful find a regerence to a docker
image in this thread:
r-spatial/discuss#28
Changes will occur quite fast, and packages need to be prepared.
The text was updated successfully, but these errors were encountered: