Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS to be mobile first #159

Closed
fulldecent opened this issue Jul 26, 2020 · 2 comments
Closed

Refactor CSS to be mobile first #159

fulldecent opened this issue Jul 26, 2020 · 2 comments

Comments

@fulldecent
Copy link

Currently, CSS is factored to have the base case be desktops (i.e. mobile code is inside @media (max-width: 760px)).

However nowadays mobile traffic is the majority. So best practice is that the CSS be written smaller viewports first and then use more specificity for larger viewports (e.g. @media (min-width: 760px)).

@daveliepmann
Copy link
Contributor

My work the last few years has been largely back-end, so I'm not familiar with that best practice. It sounds reasonable, but I'd like to see some sources. Regardless, I refer you (again) to Project Scope and Status from the README:

This project is maintained but not under active development. It is considered essentially feature-complete. Refactoring and new functionality are a very low priority. However, contributions are still welcome to fix bugs or add functionality.

I'm not going to spend the (substantial) time necessary to refactor tufte.css to fulfill a best-practices checkbox. The project works as-is and I don't plan to spend a lot of time on it unless funding is made available. If you're interested in providing funding, please contact me by email.

If you did the work and submitted a PR, I'd review it positively and it might get merged. But I'd need to see fairly comprehensive evidence showing that such a substantial change preserved functionality on a variety of devices and documents before moving forward, though. So that's a major prerequisite. Until then I'm going to close this.

@fulldecent
Copy link
Author

FYI, I'm opening issues here to document initiatives for things I am implementing that may possibly be in project scope. I'm just deciding for myself which things to contribute upstream or which to keep for myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants