-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special underlining logic no longer necessary? #137
Comments
Is there a chart of browser support for underlining that clears descenders? I can't find one on a quick search, and last I heard support was on its way but not arrived. (The quality of that support would also have to compare favorably to our current approach.) Tufte CSS is happy with the current approach until the feature is supported widely across browsers. Just Chrome support is unsatisfactory for our purposes. |
I'm adding to this thread only to caution against confusing "support for underlining that clear descenders" with support for |
https://caniuse.com/#feat=text-decoration — note footnotes 3, 4, and 5 |
Thanks for the link, Joel. Closing this for now. The time is soon but not now. Let's all keep an eye on browser support for descender-clearing both by default and through |
For reference, the browser support information for |
A discussion can be found at edwardtufte#137.
A discussion can be found at edwardtufte#137.
Chrome (and other browsers I think) now underline more intelligently, so the special-casing of underlining is not just unnecessary, depending on your point of view it's actually intrusive. Perhaps the time has come or will soon come to get rid of it. Meanwhile, I have found that this works:
And then putting back underlines yourself with
text-decoration
if you want.The text was updated successfully, but these errors were encountered: