Right clicking and Usewith bug

[conde2]

Everything started before this commit !!!!!!
900ebbd

Protocol 10.41
Latest Update.

Problem with Usewith !

When trying to usewith in itemId 1490 it uses item 4722 (border) !!!

Problem with Right clicking !

What I have is:
Stakcpos: 0 itemId: 413 -- ground
Stakcpos: 1 itemId: 4804 -- border
Stakcpos: 2 itemId: 1644 -- counter
Stakcpos: 3 itemId: 1414 -- coffin

When trying to use itemId 1414 it does not use the item instead it uses something else.
The problem seems to be with the counter !
OBS: Works on tibia client !!

[Mignari]

@BenDol I checked and 'thing->isGroundBorder()' is necessary in this line:

otclient/src/client/tile.cpp

Line 488 in 900ebbd

if(!thing->isGround() && !thing->isOnBottom() && !thing->isOnTop()) {

BTW: Why not use just one loop? like:

ThingPtr Tile::getTopMultiUseThing()
{
    if(isEmpty())
        return nullptr;

    if(CreaturePtr topCreature = getTopCreature())
        return topCreature;

    for(uint i = 0; i < m_things.size(); ++i) {
        ThingPtr thing = m_things[i];
        if(thing->isForceUse())
            return thing;

        if(!thing->isGround() && !thing->isGroundBorder() && !thing->isOnBottom() && !thing->isOnTop()) {
            if(i > 0 && thing->isSplash())
                return m_things[i - 1];
            return thing;
        }

        if(!thing->isGround() && !thing->isOnTop())
            return thing;
    }

    return m_things[0];
}

[BenDol]

I didn't write this method so you would have to ask @edubart why he did it this way, probably just code progression traces through updates just didn't get merged or something. Also why is thing->isGroundBorder() necessary here?

[hrsantiago]

In many loops, isForceUse items in the tile have priority over others. In a single for, an isForceUse item might not be used because it's below on the stack.

[hrsantiago]

It's probably trickier than that. This behaviour might change between different versions.

[Zbizu]

otland/forgottenserver#1225

[Mignari]

My pull request still does not fix all the reported bugs. Sorry.
I have tested an implementation and seems to work well for all cases.
I need some people to test this before I do a PR.

https://github.com/ottools/otclient/commit/5213569662ebfa9e6dc626d6d101507c18a5828c

Does anyone have a working fix for this? I still have the issue with the latest commits.

[vfjpl]

#1113