[BUG]: 2 Zone support broken in version 26.3.1 Stable

[nofeardh]

Hi,

yesterday weather here became cold again and my heat pump was running during the day. I noticed that after updating node red workflow to latest 26.3.1 version (wrong code version 26.4.1 written in json filename) two zone support is not working as it should. If I change required temperature for Z2, nothing happens.

I checked the code and I think issue is inside third block function after "Compare SP z1 and z2" function.

Test scenario:

• heat pump running
• water mode: compensation curve
• Z1 + Z2 active
• heat request temp change for Z2

Result:

• output of "Compare SP z1 and z2" function: null, null, object
• third block function error (see sceenshot below)

Kind regards,
Aljosa

[edterbak]

Thank you for the detailed report !!!

is your pump set to use compensation curve? or direct mode?
Do you expect a single setpoint or a curve shift.

/edit

aaaaah... the zone 1 is hardcoded indeed in the formula.

[nofeardh]

pump is set to compensation curve...as you already figured out Z1 is hardcoded and temp shift is working only for Z1 and not for Z2.

[edterbak]

can you test this code in the 3rd [Block] node?

Cut out

[edterbak]

ah wait, there is a error in it still. one second

[edterbak]

ugh... every step taken in the payload.zoneX.heat.high... is forms a roadbump.. oke.. trying to tackle it.

[edterbak]

Oke, I found 'optional chaining'. It seems to work in node red js.
In my setup it works. can you try this code?

var last_value_z1 = context.get('last_value_z1');
var last_value_z2 = context.get('last_value_z2');
var varCheck = 0 ;

let z1 = msg.payload?.zone1?.heat?.target?.high;
let z2 = msg.payload?.zone2?.heat?.target?.high;

if ((last_value_z1 !== undefined && z1 === last_value_z1) || z1 === undefined) { varCheck++ }
if ((last_value_z2 !== undefined && z2 === last_value_z2) || z2 === undefined) { varCheck++ }
if (varCheck == 2) { return null }

if (z1 !== undefined) context.set('last_value_z1', z1);
if (z2 !== undefined) context.set('last_value_z2', z2);

if (global.get('MQTT.block_active', "file") === 1) {
    let msg99 = {}; // pin 2 - To Log
    msg99.topic = "SYSTEM";
    msg99.payload = "MQTT-Commands are blocked, did not send MQTT - " + msg.topic + " " + msg.payload;
    global.set('MQTT_Source', undefined); // clear if blocked
    return [null, msg99];
    }

if (global.get('MQTT_Source') === undefined) { global.set('MQTT_Source', "SP Calculation"); }// only set when undefined

return [msg, null]; //send SP

[nofeardh]

Seems to be working OK for now. I will monitor it closely for a while and will let you know if It's ok.

Many thanks for very quick update!

[edterbak]

Thanks for testing.No worries. Good to read it is working with zone 2. For me with zone 1 it is working too.

No heat is kind of annoying. Sorry
Hopefully this is a good fix.
I will wait for release until you confirm finally..

[edterbak]

FYI;
2 days ago, I have also done some cleanup of legacy variables for zone 2 CCC. Some variables were still using WAR in the name, without distinction of zone 1/2. So I corrected this I think. This is in my current local and will come with next release, including the fix here...

The next release, I would like you to keep a close eye on this part too if that is alright. 😄

[nofeardh]

Yes of course....just be quick with the release since weather is still cold here :)

BTW....Z1 & Z2 seems to be working OK here (together with CCC & RTC active).

[nofeardh]

Forgot to mention....during debug sessions I noticed there is an error inside "Function schedule". I added debug printout node.warn(day_check); and below you can see that sometimes day_check variable is undefined. Altough scheduler seems to be working OK.

[edterbak]

Forgot to mention....during debug sessions I noticed there is an error inside "Function schedule". I added debug printout node.warn(day_check); and below you can see that sometimes day_check variable is undefined. Altough scheduler seems to be working OK.

I think this error comes up for a line where you have never entered a schedule at all. Therefor the global stored variable Schedule_X_day does not exist. This fits the picture that everything is working anyway.

I have added a sanity check to verify if a day/hour/minute has been entered.
I included it in my current local.
I will now release this version. v26-5-1