Merge pull request #62 from edmondscommerce/PhpUnitIterativeMode

Php unit iterative mode

Author: edmondscommerce

bin/phpunit-runfailed-filter

@@ -2,6 +2,24 @@
 
 Here is the full documentation about how you can use and configure PHPUnit in your PHPQA project.
 
+## Iterative Mode
+
+When you have tests that are failing and you are working towards getting everything green, then you might want to try iterative mode.
+
+The easiest way to do this is:
+
+```bash
+./bin/qa -t uniterate
+```
+
+This will run PHPunit in isolation
+
+The first run will be a full run (unless you have done one previously)
+
+Subsequent runs will then run your failed tests first and will stop on the first error.
+
+This allows you to quickly iterate on your test suite and push it towards getting everything passing.
+
 ## Quick Tests
 
 There is an environment variable for PHPUnit set called `phpUnitQuickTests`
@@ -129,21 +147,6 @@ We suggest that you install [https://github.com/phpstan/phpstan-phpunit](https:/
 
 Read the [PHPQA PHPStan docs](./phpstan.md) for more information on this.
 
-
-## Rerun Failed Tests
-
-As with the other tools, there is an option to rerun this step if it fails.
-
-Where PHPUnit is different is that you also get the option to only rerun your failed tests.
-
-This uses another bin command [./bin/phpunit-runfailed-filter](./../../bin/phpunit-runfailed-filter) which generates the filter syntax to pull out the failed tests.
-
-You can also use this in isolation if you want, eg:
-
-```bash
-./bin/phpunit -c qaConfig/phpunit.xml --filter "$(bin/phpunit-runfailed-filter)" tests/
-```
-
 ## Infection
 
 Another tool that runs your PHPUnit tests is Infection. This will only run if Xdebug is enabled and you have configured PHPUnit to generate coverage.

docs/tools/phpunit.md

@@ -22,20 +22,6 @@ phpunitExitCode=99
 phpunitLogFilePath="$varDir/phpunit_logs/phpunit.junit.xml"
 while (( phpunitExitCode > 0 ))
 do
-    declare -a rerunFilter
-    rerunFilter=(" ")
-# THIS ISNT WORKING AT THE MOMENT - COMMENTING OUT FOR NOW
-#    if phpunitReRunFailedOrFull
-#    then
-#        #set no glob
-#        set -f
-#        rerunFilterPattern=$(phpNoXdebug bin/phpunit-runfailed-filter)
-#        if [[ "$rerunFilterPattern" != '/.*/' ]]
-#        then
-#            rerunFilter+=( --filter $IFS $rerunFilterPattern)
-#            phpunitFailedOnlyFiltered=1
-#        fi
-#    fi
     extraConfigs=(" ")
     if [[ "1" != "$phpUnitCoverage" ]]
     then
@@ -49,14 +35,14 @@ do
         echo
         extraConfigs+=( --order-by=depends,defects )
         extraConfigs+=( --stop-on-failure --stop-on-error --stop-on-defect --stop-on-warning )
+        extraConfigs+=( --no-coverage )
     fi
     set +e
     set -x
     phpUnitQuickTests="$phpUnitQuickTests" $phpCmd -f $phpunitPath \
         -- \
         ${paratestConfig[@]} \
         -c ${phpUnitConfigPath} \
-        ${rerunFilter[@]} \
         ${extraConfigs[@]} \
         --enforce-time-limit \
         --fail-on-risky \

includes/generic/phpunit.inc.bash

@@ -46,9 +46,6 @@ phpUnitQuickTests=${phpUnitQuickTests:-0}
 # if enabled, tests will run with Xdebug and generate coverage (which is a lot slower)
 phpUnitCoverage=${phpUnitCoverage:-1}
 
-# How many minutes after a failed PHPUnit run you can retry failed only
-phpunitRerunTimeoutMins=${phpunitRerunTimeoutMins:-5}
-
 # Can only generate coverage if Xdebug is enabled
 if [[ "1" != "$xdebugEnabled" ]]
 then