Adding plugins to action tools

Author: zaucy

ecsact/private/ecsact_codegen.bzl

@@ -7,6 +7,7 @@ def _ecsact_codegen(ctx):
     info = ctx.toolchains["//ecsact:toolchain_type"].ecsact_info
 
     outputs = []
+    tools = [] + info.tool_files
     outdir = ctx.actions.declare_directory(ctx.attr.name)
 
     args = ctx.actions.args()
@@ -21,12 +22,15 @@ def _ecsact_codegen(ctx):
             out_basename = ctx.attr.name + "/" + src.basename
             outputs.append(ctx.actions.declare_file(out_basename + "." + plugin_info.output_extension))
 
+    for p in info.target_tool_path_runfiles:
+        tools.extend(p.files.to_list())
+
     ctx.actions.run(
         mnemonic = "EcsactCodegen",
         outputs = [outdir] + outputs,
         inputs = ctx.files.srcs,
         executable = info.target_tool_path,
-        tools = info.tool_files,
+        tools = tools,
         arguments = [args],
     )
 

ecsact/repositories.bzl

@@ -75,9 +75,12 @@ load("@rules_ecsact//ecsact:toolchain.bzl", "ecsact_toolchain")
 
 package(default_visibility = ["//visibility:public"])
 
+exports_files(glob(["share/**/*", "bin/**/*"]))
+
 ecsact_toolchain(
     name = "ecsact_toolchain",
     target_tool_path = "{target_tool_path}",
+    target_tool_path_runfiles = [{target_tool_path_runfiles}],
 )
 """
 
@@ -132,6 +135,7 @@ def _ecsact_host_repo_impl(rctx):
     ecsact_executable_name = "ecsact" + exe_extension
 
     ecsact_path = rctx.which(ecsact_executable_name)
+    target_tool_path_runfiles = []
 
     if ecsact_path == None and is_windows:
         pwsh = rctx.which("pwsh.exe")
@@ -143,12 +147,22 @@ def _ecsact_host_repo_impl(rctx):
         if ecsact_sdk_install_dir:
             ecsact_sdk_install_dir = ecsact_sdk_install_dir.replace("\\", "/").strip()
             ecsact_path = ecsact_sdk_install_dir + "/bin/ecsact.exe"
+            ecsact_config = json.decode(rctx.execute([ecsact_path, "config"]).stdout)
+            ecsact_plugin_dir = ecsact_config["plugin_dir"].replace("\\", "/")
+            rctx.symlink(ecsact_path, "bin/ecsact.exe")
+            for plugin in ecsact_config["builtin_plugins"]:
+                plugin_filename = "ecsact_" + plugin + "_codegen.dll"
+                plugin_abs_path = ecsact_plugin_dir + "/" + plugin_filename
+                plugin_local_path = "share/ecsact/" + plugin_filename
+                rctx.symlink(plugin_abs_path, plugin_local_path)
+                target_tool_path_runfiles.append("\"" + plugin_local_path + "\"")
 
     if ecsact_path == None:
         rctx.file("BUILD.bazel", "")
     else:
         rctx.file("BUILD.bazel", _HOST_BUILD_CONTENT.format(
             target_tool_path = ecsact_path,
+            target_tool_path_runfiles = ", ".join(target_tool_path_runfiles),
         ))
 
     rctx.file("codegen_plugins/BUILD.bazel", _CODEGEN_BUILD_CONTENT)

ecsact/toolchain.bzl

@@ -5,6 +5,7 @@ EcsactInfo = provider(
     doc = "Information about how to invoke the tool executable.",
     fields = {
         "target_tool_path": "Path to the tool executable for the target platform.",
+        "target_tool_path_runfiles": "",
         "tool_files": """Files required in runfiles to make the tool executable available.
 
 May be empty if the target_tool_path points to a locally installed tool binary.""",
@@ -23,6 +24,8 @@ def _ecsact_toolchain_impl(ctx):
         fail("Can only set one of target_tool or target_tool_path but both were set.")
     if not ctx.attr.target_tool and not ctx.attr.target_tool_path:
         fail("Must set one of target_tool or target_tool_path.")
+    if ctx.attr.target_tool and ctx.attr.target_tool_path_runfiles:
+        fail("Cannot use target_tool_path_runfiles with target_tool.")
 
     tool_files = []
     target_tool_path = ctx.attr.target_tool_path
@@ -42,6 +45,7 @@ def _ecsact_toolchain_impl(ctx):
     )
     ecsact_info = EcsactInfo(
         target_tool_path = target_tool_path,
+        target_tool_path_runfiles = ctx.attr.target_tool_path_runfiles,
         tool_files = tool_files,
     )
 
@@ -70,6 +74,11 @@ ecsact_toolchain = rule(
             doc = "Path to an existing executable for the target platform.",
             mandatory = False,
         ),
+        "target_tool_path_runfiles": attr.label_list(
+            doc = "List of files needed at runtime for `target_tool_path`. Not valid with `target_tool`.",
+            mandatory = False,
+            allow_files = True,
+        ),
     },
     doc = """Defines a ecsact compiler/runtime toolchain.