Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper tests #32

Open
floriankrb opened this issue Nov 20, 2024 · 0 comments
Open

Add proper tests #32

floriankrb opened this issue Nov 20, 2024 · 0 comments

Comments

@floriankrb
Copy link
Member

The current tests do not pass in the ci. They need to be run manually and this is not a good practice.

Points to solve to do this:

  • The granularity of these tests may not be correct. They need a new dataset to register it in the catalogue. To have this anemoi-datasets is needed. They are not unit testing, but closer to integration testing.
  • They actually use the real anemoi.ecmwf.int production server, we would need a dedicated test server. Or change the granularity.
  • They need admin credential to the server, which makes it difficult for contributors to run the tests locally before submitting a PR.

Somehow, this is related/would be addressed with having proper integration tests for the whole anemoi-* packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant