Skip to content

Commit 36aa7c2

Browse files
committed
Merge pull request #23 from eclopez/emergency-bugfix
Emergency bugfix
2 parents 67b1eff + e4beba8 commit 36aa7c2

6 files changed

Lines changed: 19 additions & 31 deletions

File tree

SteamGenius/SGBattleDetailViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(N
159159
}
160160
break;
161161
case 2:
162-
cell.textLabel.text = self.battle.controlPoints ? [NSString stringWithFormat:@"%@ control points", [self.battle.killPoints stringValue]] : @"No control points entered";
162+
cell.textLabel.text = self.battle.controlPoints ? [NSString stringWithFormat:@"%@ control points", [self.battle.controlPoints stringValue]] : @"No control points entered";
163163
if (!self.battle.controlPoints) {
164164
isEmptyData = YES;
165165
}

SteamGenius/SGBattleFormViewController.m

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ - (IBAction)saveBattle:(id)sender {
7575
self.battle.event = form.event;
7676
self.battle.notes = form.notes;
7777
} else {
78-
[SGRepository initWithPlayerCaster:form.playerCaster opponentCaster:form.opponentCaster opponent:form.opponent date:form.date points:form.pointSize result:form.result killPoints:form.killPoints scenario:form.scenario controlPoints:form.controlPoints event:form.event notes:form.notes context:appDelegate.managedObjectContext];
78+
[SGRepository initWithPlayerCaster:form.playerCaster opponentCaster:form.opponentCaster opponent:form.opponent date:[self normalizedDate:form.date] points:form.pointSize result:form.result killPoints:form.killPoints scenario:form.scenario controlPoints:form.controlPoints event:form.event notes:form.notes context:appDelegate.managedObjectContext];
7979
}
8080
[appDelegate saveContext];
8181
[self.navigationController dismissViewControllerAnimated:YES completion:nil];
@@ -88,14 +88,11 @@ - (IBAction)saveBattle:(id)sender {
8888
#pragma mark - Utilities
8989

9090
- (NSDate *)normalizedDate:(NSDate *)date {
91-
NSCalendar *calendar = [NSCalendar currentCalendar];
91+
NSCalendar *calendar = [[NSCalendar alloc] initWithCalendarIdentifier:NSCalendarIdentifierGregorian];
92+
date = [calendar startOfDayForDate:date];
9293
calendar.timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0];
93-
NSDateComponents *dateComponents = [calendar components:(NSCalendarUnitYear | NSCalendarUnitMonth | NSCalendarUnitDay) fromDate:date];
94-
[dateComponents setHour:12];
95-
[dateComponents setMinute:0];
96-
[dateComponents setSecond:0];
97-
[dateComponents setNanosecond:0];
98-
return [calendar dateFromComponents:dateComponents];
94+
NSTimeInterval twelveHours = 12 * 3600;
95+
return [[calendar startOfDayForDate:date] dateByAddingTimeInterval:twelveHours];
9996
}
10097

10198
@end

SteamGenius/SGEventFormViewController.m

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,11 @@ - (void)cancelEvent {
7878
#pragma mark - Utilities
7979

8080
- (NSDate *)normalizedDate:(NSDate *)date {
81-
NSCalendar *calendar = [NSCalendar currentCalendar];
81+
NSCalendar *calendar = [[NSCalendar alloc] initWithCalendarIdentifier:NSCalendarIdentifierGregorian];
82+
date = [calendar startOfDayForDate:date];
8283
calendar.timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0];
83-
NSDateComponents *dateComponents = [calendar components:(NSCalendarUnitYear | NSCalendarUnitMonth | NSCalendarUnitDay) fromDate:date];
84-
[dateComponents setHour:12];
85-
[dateComponents setMinute:0];
86-
[dateComponents setSecond:0];
87-
[dateComponents setNanosecond:0];
88-
return [calendar dateFromComponents:dateComponents];
84+
NSTimeInterval twelveHours = 12 * 3600;
85+
return [[calendar startOfDayForDate:date] dateByAddingTimeInterval:twelveHours];
8986
}
9087

9188
@end

SteamGenius/SGFiltersFormViewController.m

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,14 +112,11 @@ - (void)reloadForm {
112112
#pragma mark - Utilities
113113

114114
- (NSDate *)normalizedDate:(NSDate *)date {
115-
NSCalendar *calendar = [NSCalendar currentCalendar];
115+
NSCalendar *calendar = [[NSCalendar alloc] initWithCalendarIdentifier:NSCalendarIdentifierGregorian];
116+
date = [calendar startOfDayForDate:date];
116117
calendar.timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0];
117-
NSDateComponents *dateComponents = [calendar components:(NSCalendarUnitYear | NSCalendarUnitMonth | NSCalendarUnitDay) fromDate:date];
118-
[dateComponents setHour:12];
119-
[dateComponents setMinute:0];
120-
[dateComponents setSecond:0];
121-
[dateComponents setNanosecond:0];
122-
return [calendar dateFromComponents:dateComponents];
118+
NSTimeInterval twelveHours = 12 * 3600;
119+
return [[calendar startOfDayForDate:date] dateByAddingTimeInterval:twelveHours];
123120
}
124121

125122
@end

SteamGenius/SGRepository.m

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,14 +128,11 @@ + (BattleFilter *)initWithDisplayText:(NSString *)displayText predicate:(NSPredi
128128
#pragma mark - Utilities
129129

130130
+ (NSDate *)normalizedDate:(NSDate *)date {
131-
NSCalendar *calendar = [NSCalendar currentCalendar];
131+
NSCalendar *calendar = [[NSCalendar alloc] initWithCalendarIdentifier:NSCalendarIdentifierGregorian];
132+
date = [calendar startOfDayForDate:date];
132133
calendar.timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0];
133-
NSDateComponents *dateComponents = [calendar components:(NSCalendarUnitYear | NSCalendarUnitMonth | NSCalendarUnitDay) fromDate:date];
134-
[dateComponents setHour:12];
135-
[dateComponents setMinute:0];
136-
[dateComponents setSecond:0];
137-
[dateComponents setNanosecond:0];
138-
return [calendar dateFromComponents:dateComponents];
134+
NSTimeInterval twelveHours = 12 * 3600;
135+
return [[calendar startOfDayForDate:date] dateByAddingTimeInterval:twelveHours];
139136
}
140137

141138
@end

SteamGeniusTests/SteamGeniusTests.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ - (void)testAddResult {
7373
// Assert
7474
NSFetchRequest *req = [[NSFetchRequest alloc] initWithEntityName:@"Result"];
7575
NSArray *arr = [_moc executeFetchRequest:req error:nil];
76-
XCTAssertEqual(15, [arr count]);
76+
XCTAssertEqual(19, [arr count]);
7777
}
7878

7979
- (void)testAddOpponent {

0 commit comments

Comments
 (0)