Skip to content

Commit 14fec60

Browse files
committed
Remove xvfb action and use it directly
As it turns out (see coactions/setup-xvfb#21), it is available in our container anyway. Also pin the Python version to 3.11. Change-Id: Id8d2416996ea489675ca7e50da59286af1965777
1 parent 19b2abc commit 14fec60

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

.github/workflows/performance-tests.yml

+6-8
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ jobs:
2020
node-version: "18.x"
2121
registry-url: "https://registry.npmjs.org"
2222

23-
- name: Use Python 3.x
23+
- name: Use Python 3.11
2424
uses: actions/setup-python@v4
2525
with:
26-
python-version: "3.x"
26+
python-version: '3.11'
2727

2828
- name: Build
2929
shell: bash
@@ -36,14 +36,12 @@ jobs:
3636
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
3737

3838
- name: Performance (browser)
39-
uses: coactions/setup-xvfb@v1
40-
with:
41-
run: yarn performance:startup:browser
39+
shell: bash
40+
run: yarn performance:startup:browser
4241

4342
- name: Performance (Electron)
44-
uses: coactions/setup-xvfb@v1
45-
with:
46-
run: yarn performance:startup:electron
43+
shell: bash
44+
run: xvfb-run yarn performance:startup:electron
4745

4846
- name: Analyze performance results
4947
uses: benchmark-action/github-action-benchmark@v1

0 commit comments

Comments
 (0)