Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoolOptions copy constructor doesn't copy all fields #1501

Closed
tsegismont opened this issue Mar 20, 2025 · 1 comment
Closed

PoolOptions copy constructor doesn't copy all fields #1501

tsegismont opened this issue Mar 20, 2025 · 1 comment
Assignees
@tsegismont
Labels
bug
Milestone
4.5.14

Comments

@tsegismont
Copy link
Contributor

Fields missing:

  • maxLifetime
  • maxLifetimeUnit
  • poolCleanerPeriod
  • connectionTimeout
  • connectionTimeoutUnit
@tsegismont tsegismont added the bug label Mar 20, 2025
@tsegismont tsegismont added this to the 4.5.14 milestone Mar 20, 2025
@tsegismont tsegismont self-assigned this Mar 20, 2025
tsegismont added a commit to tsegismont/vertx-sql-client that referenced this issue Mar 20, 2025
@tsegismont
PoolOptions copy constructor doesn't copy all fields
6f05395 
See eclipse-vertx#1501

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Mar 20, 2025
Merged
tsegismont added a commit to tsegismont/vertx-sql-client that referenced this issue Mar 20, 2025
@tsegismont
PoolOptions copy constructor doesn't copy all fields
94bbb2a 
See eclipse-vertx#1501

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit that referenced this issue Mar 20, 2025
@tsegismont
PoolOptions copy constructor doesn't copy all fields (#1502)
459283d 
See #1501

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit that referenced this issue Mar 20, 2025
@tsegismont
PoolOptions copy constructor doesn't copy all fields (#1503)
bb2b3df 
See #1501

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont
Copy link
Contributor Author

Fixed by #1503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsegismont tsegismont

Labels
bug
Projects
None yet
Milestone
4.5.14
Development

No branches or pull requests
1 participant
@tsegismont