Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should throw error on VertxGen declared inside VertxGen/DataObject #319

Open
pmlopes opened this issue Dec 10, 2020 · 1 comment
Open

Should throw error on VertxGen declared inside VertxGen/DataObject #319

pmlopes opened this issue Dec 10, 2020 · 1 comment
Labels

Comments

@pmlopes
Copy link
Contributor

pmlopes commented Dec 10, 2020

Currently, I've noticed a few generation errors regarding how classes and interfaces are annotated.

For example, if a @VertxGen interface has a enum declared inside, this will be valid java code and will compile and no warning is given by codegen. However, you will not be able to process such element.

@VertxGen
interface A {
  @VertxGen
  enum E { }
}

In the example above E will never be processed and no warning or error is raised. I think we should raise an error in this situation.

The same applies for @DataObject. During the processing we should guarantee that this isn't allowed. This pattern is a problem to es4x but may not be for other generators, so we may agree in raising a warning instead.

@pmlopes pmlopes added the bug label Dec 10, 2020
@pmlopes
Copy link
Contributor Author

pmlopes commented Dec 10, 2020

@cescoffier @codepitbull you also work with codegen can you check if this also affects you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant