Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dialog: add progress bar #427

Open
nimo23 opened this issue Dec 7, 2024 · 3 comments
Open

Update dialog: add progress bar #427

nimo23 opened this issue Dec 7, 2024 · 3 comments

Comments

@nimo23
Copy link

nimo23 commented Dec 7, 2024

Feature Description:

Please add a progress information (e.g. "10% completed" or better "20MB of 180MB downloaded") to the progressbar when updating:

Screenshot at Dec 07 23-06-38

@nimo23 nimo23 changed the title Update dialog: please add progress Update dialog: please add progress bar Dec 7, 2024
@nimo23 nimo23 changed the title Update dialog: please add progress bar Update dialog: add progress bar Dec 7, 2024
@jfaltermeier
Copy link
Contributor

In the past, we had issues where the progress reported by electron-updater was either missing or incorrect, so we chose an indeterminate progress bar. We should check if this has improved.

@jfaltermeier
Copy link
Contributor

As far as I can tell, we do not enter this if case: https://github.com/electron-userland/electron-builder/blob/9b72f3deebc4daeed5781db10b57adf4dd7513ec/packages/electron-updater/src/differentialDownloader/DifferentialDownloader.ts#L134. As noted in the comment, multiple ranges are not supported, so no progress is reported.

@nimo23
Copy link
Author

nimo23 commented Dec 12, 2024

In VSCode, the progressbar shows progress state, etc. Maybe it uses a 3rd party progressbar which can be used here..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants