Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage com.google.inject.spi.ProvisionListener to implement Lifecycle Support #176

Open
kwin opened this issue Sep 23, 2024 · 7 comments

Comments

@kwin
Copy link
Contributor

kwin commented Sep 23, 2024

Currently the lifecycle support in relies on TypeListener for calling the post construct methods (https://github.com/eclipse-sisu/sisu-project/blob/3a8b268b246603fa53b1946aef3a663aa27fc58d/org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/LifecycleModule.java#L86C39-L86C51). Instead one should use https://google.github.io/guice/api-docs/latest/javadoc/com/google/inject/spi/ProvisionListener.html being introduced with Guice 4 (compare with google/guice#62 (comment)).

@kwin
Copy link
Contributor Author

kwin commented Sep 23, 2024

This requires dropping support of Guice 3 (from 2011) and only support Guice 4 or newer (from 2015). Any concerns @mcculls or @cstamas?

@cstamas
Copy link
Member

cstamas commented Sep 23, 2024

None from me

kwin added a commit that referenced this issue Sep 30, 2024
@slachiewicz
Copy link
Contributor

What about jump to Guice 6?

@kwin
Copy link
Contributor Author

kwin commented Oct 13, 2024

This is only about the minimum version being supported. Newer versions are already checked in ITs and work fine.

@slachiewicz
Copy link
Contributor

I know. I mean, bump the minimum supported version just to Guice 6 as it's relatively fresh, supports Jakarta and javax annotations.

@kwin
Copy link
Contributor Author

kwin commented Oct 14, 2024

For what reason? I wouldn’t bump without a need. There is currently no other new Guice API we need to leverage (which is only provided in 6+).

@slachiewicz
Copy link
Contributor

Ok. One potential advantage would be the possibility to open to Jakarta namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants