-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage com.google.inject.spi.ProvisionListener to implement Lifecycle Support #176
Comments
None from me |
What about jump to Guice 6? |
This is only about the minimum version being supported. Newer versions are already checked in ITs and work fine. |
I know. I mean, bump the minimum supported version just to Guice 6 as it's relatively fresh, supports Jakarta and javax annotations. |
For what reason? I wouldn’t bump without a need. There is currently no other new Guice API we need to leverage (which is only provided in 6+). |
Ok. One potential advantage would be the possibility to open to Jakarta namespaces. |
Currently the lifecycle support in relies on
TypeListener
for calling the post construct methods (https://github.com/eclipse-sisu/sisu-project/blob/3a8b268b246603fa53b1946aef3a663aa27fc58d/org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/LifecycleModule.java#L86C39-L86C51). Instead one should use https://google.github.io/guice/api-docs/latest/javadoc/com/google/inject/spi/ProvisionListener.html being introduced with Guice 4 (compare with google/guice#62 (comment)).The text was updated successfully, but these errors were encountered: