[win][21] XmlDocumentFormatterTest fails since I20250113-1800

[jukzi]

https://download.eclipse.org/eclipse/downloads/drops4/I20250113-1800/testresults/html/org.eclipse.ant.tests.ui_ep435I-unit-win32-x86_64-java21_win32.win32.x86_64_21.html

org.junit.ComparisonFailure: expected:<...<!-- = = = = = = -->[
<!-- formatTest -->
<!-- = = = = = = -->
<target name="formatTest" depends="init" description="--> test target one">
<!-- hello world -->
<greeting />
</target>

<!-- - - - - - - -->
<!-- init -->
<!-- - - - - - - -->
<target name="init">
<property name="greeting" value="hi" />
<presetdef name="greeting">]
<echo>${gr...> but was:<...<!-- = = = = = = -->[
<!-- formatTest -->
<!-- = = = = = = -->
<target name="formatTest" depends="init" description="--> test target one">
<!-- hello world -->
<greeting />
</target>

<!-- - - - - - - -->
<!-- init -->
<!-- - - - - - - -->
<target name="init">
<property name="greeting" value="hi" />
<presetdef name="greeting">
]
<echo>${gr...>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at org.eclipse.ant.tests.ui.editor.formatter.XmlDocumentFormatterTest.simpleTest(XmlDocumentFormatterTest.java:100)
at org.eclipse.ant.tests.ui.editor.formatter.XmlDocumentFormatterTest.testGeneralFormat(XmlDocumentFormatterTest.java:44)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at org.eclipse.ant.tests.ui.testplugin.TestAgainExceptionRule$1.evaluate(TestAgainExceptionRule.java:39)

org.junit.ComparisonFailure: expected:<...<!-- = = = = = = -->[
<!-- formatTest -->
<!-- = = = = = = -->
<target name="formatTest" depends="init" description="--> test target one">
<!-- hello world -->
<greeting />
</target>
<!-- - - - - - - -->
<!-- init -->
<!-- - - - - - - -->
<target name="init">
<property name="greeting" value="hi" />
<presetdef name="greeting">]
<echo>${greeting...> but was:<...<!-- = = = = = = -->[
<!-- formatTest -->
<!-- = = = = = = -->
<target name="formatTest" depends="init" description="--> test target one">
<!-- hello world -->
<greeting />
</target>

<!-- - - - - - - -->
<!-- init -->
<!-- - - - - - - -->
<target name="init">
<property name="greeting" value="hi" />
<presetdef name="greeting">
]
<echo>${greeting...>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at org.eclipse.ant.tests.ui.editor.formatter.XmlDocumentFormatterTest.simpleTest(XmlDocumentFormatterTest.java:100)
at org.eclipse.ant.tests.ui.editor.formatter.XmlDocumentFormatterTest.testTabsInsteadOfSpaces(XmlDocumentFormatterTest.java:82)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at org.eclipse.ant.tests.ui.testplugin.TestAgainExceptionRule$1.evaluate(TestAgainExceptionRule.java:39)

expected:<...<!-- = = = = = = -->[ <!-- formatTest --> <!-- = = = = = = --> <target name="formatTest" depends="init" description="--> test target one"> <!-- hello world --> <greeting /> </target> <!-- - - - - - - --> <!-- init --> <!-- - - - - - - --> <target name="init"> <property name="greeting" value="hi" /> <presetdef name="greeting">] ...> but was:<...<!-- = = = = = = -->[ <!-- formatTest --> <!-- = = = = = = --> <target name="formatTest" depends="init" description="--> test target one"> <!-- hello world --> <greeting /> </target> <!-- - - - - - - --> <!-- init --> <!-- - - - - - - --> <target name="init"> <property name="greeting" value="hi" /> <presetdef name="greeting"> ] ...>

org.junit.ComparisonFailure: expected:<...<!-- = = = = = = -->[
<!-- formatTest -->
<!-- = = = = = = -->
<target name="formatTest" depends="init" description="--> test target one">
<!-- hello world -->
<greeting />
</target>

<!-- - - - - - - -->
<!-- init -->
<!-- - - - - - - -->
<target name="init">
<property name="greeting" value="hi" />
<presetdef name="greeting">]
...> but was:<...<!-- = = = = = = -->[
<!-- formatTest -->
<!-- = = = = = = -->
<target name="formatTest" depends="init" description="--> test target one">
<!-- hello world -->
<greeting />
</target>

<!-- - - - - - - -->
<!-- init -->
<!-- - - - - - - -->
<target name="init">
<property name="greeting" value="hi" />
<presetdef name="greeting">
]
...>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at org.eclipse.ant.tests.ui.editor.formatter.XmlDocumentFormatterTest.simpleTest(XmlDocumentFormatterTest.java:100)
at org.eclipse.ant.tests.ui.editor.formatter.XmlDocumentFormatterTest.testTabWidth(XmlDocumentFormatterTest.java:63)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at org.eclipse.ant.tests.ui.testplugin.TestAgainExceptionRule$1.evaluate(TestAgainExceptionRule.java:39)

[jukzi]

Fails each java21_win32 i-build now. Can not locally reproduce.

[jukzi]

seems to be an issue with an additional newline:

[akurtakov]

Could it be related to eclipse-platform/eclipse.platform.swt#1732 ?

[jukzi]

i guess its regression from 0a723c5 because that which was committed 01-13 and modified the test @akurtakov can you check? maybe revert just that lines to verify?

Could it be related to eclipse-platform/eclipse.platform.swt#1732 ?

no, that was commited later

[jukzi]

org.eclipse.ant.tests.ui.testplugin.AbstractAntUITest.getReaderContentAsString(BufferedReader) used to unify any newlines with System.lineSeparator(), which Files.readString does not

[akurtakov]

I'm on it.

[jukzi]

fixed in https://download.eclipse.org/eclipse/downloads/drops4/I20250123-1800/testResults.php