Skip to content

Commit 7163c9e

Browse files
committed
Remove sorting parameter from ConfigurationSessionTestSuite #903
The ConfigurationSessionTestSuite sorts the test methods by default. A field identifies whether sorting is activated, but the field cannot even be set but is always true. So, this parameterization is completely obsolete and only introduces unnecessary complexity to the session test framework. Contributes to #903
1 parent a2ad0b3 commit 7163c9e

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

runtime/tests/org.eclipse.core.tests.harness/src/org/eclipse/core/tests/session/ConfigurationSessionTestSuite.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,9 @@ public class ConfigurationSessionTestSuite extends SessionTestSuite {
6262
private IPath configurationPath = FileSystemHelper.getRandomLocation(FileSystemHelper.getTempDir());
6363
private boolean prime = true;
6464
private boolean readOnly;
65-
// should the test cases be run in alphabetical order?
66-
private boolean shouldSort;
6765

6866
public ConfigurationSessionTestSuite(String pluginId, Class<?> theClass) {
6967
super(pluginId, theClass);
70-
this.shouldSort = true;
7168
}
7269

7370
public ConfigurationSessionTestSuite(String pluginId, String name) {
@@ -269,7 +266,7 @@ public void run(TestResult result) {
269266
fail(e);
270267
}
271268
}
272-
if (!shouldSort || isSharedSession()) {
269+
if (isSharedSession()) {
273270
// for shared sessions, we don't control the execution of test cases
274271
super.run(result);
275272
return;

0 commit comments

Comments
 (0)