Skip to content

Commit 03e472f

Browse files
committed
Additional Separator
This PR provides additional separation and arrangements between Enable/Disable Actions in breakpoints view. New actions can be contributed here. Part of Enhancement #eclipse-jdt/eclipse.jdt.debug#550
1 parent 3776c2f commit 03e472f

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

Diff for: debug/org.eclipse.debug.ui/plugin.xml

+6-6
Original file line numberDiff line numberDiff line change
@@ -1505,38 +1505,38 @@
15051505
definitionId="org.eclipse.ui.edit.copy"
15061506
helpContextId="copy_breakpoints_action_context"
15071507
class="org.eclipse.debug.internal.ui.actions.breakpointGroups.CopyBreakpointsActionDelegate"
1508-
menubarPath="breakpointGroup"
1508+
menubarPath="BreakpointAdditionalGroup"
15091509
id="org.eclipse.debug.ui.breakpointsView.toolbar.copy"/>
15101510
<action
15111511
label="%SelectAll.label"
15121512
helpContextId="select_all_breakpoints_action_context"
15131513
definitionId="org.eclipse.ui.edit.selectAll"
15141514
class="org.eclipse.debug.internal.ui.actions.breakpoints.SelectAllBreakpointsAction"
1515-
menubarPath="breakpointGroup"
1515+
menubarPath="BreakpointAdditionalGroup"
15161516
id="org.eclipse.debug.ui.actions.SelectAllBreakpointsAction">
15171517
</action>
15181518
<action
15191519
label="%RemoveAllAction.label"
15201520
icon="$nl$/icons/full/elcl16/rem_all_co.png"
15211521
helpContextId="remove_all_breakpoints_action_context"
15221522
class="org.eclipse.debug.internal.ui.actions.breakpoints.RemoveAllBreakpointsAction"
1523-
menubarPath="breakpointGroup"
1523+
menubarPath="BreakpointAdditionalGroup"
15241524
id="org.eclipse.debug.ui.actions.RemoveAllBreakpoints">
15251525
</action>
15261526
<action
15271527
label="%RemoveAllTriggerpoints.label"
15281528
icon="$nl$/icons/full/elcl16/rem_all_triggers.png"
15291529
helpContextId="remove_all_breakpoints_action_context"
15301530
class="org.eclipse.debug.internal.ui.actions.breakpoints.RemoveAllTriggerPointsAction"
1531-
menubarPath="breakpointGroup"
1531+
menubarPath="BreakpointAdditionalGroup"
15321532
id="org.eclipse.debug.ui.actions.RemoveAllTriggerpoints">
15331533
</action>
15341534
<action
15351535
label="%RemoveAction.label"
15361536
icon="$nl$/icons/full/elcl16/rem_co.png"
15371537
helpContextId="remove_breakpoint_action_context"
15381538
class="org.eclipse.debug.internal.ui.actions.breakpoints.RemoveBreakpointAction"
1539-
menubarPath="breakpointGroup"
1539+
menubarPath="BreakpointAdditionalGroup"
15401540
enablesFor="+"
15411541
id="org.eclipse.debug.ui.breakpointsView.toolbar.remove">
15421542
</action>
@@ -1545,7 +1545,7 @@
15451545
icon="$nl$/icons/full/elcl16/disabled_co.png"
15461546
helpContextId="disable_breakpoint_action_context"
15471547
class="org.eclipse.debug.internal.ui.actions.breakpoints.DisableAllBreakpointsAction"
1548-
menubarPath="breakpointGroup"
1548+
menubarPath="BreakpointAdditionalGroup"
15491549
id="org.eclipse.debug.ui.actions.DisableAllBreakpoint">
15501550
</action>
15511551
<action

Diff for: debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/BreakpointsView.java

+3
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,9 @@ protected void fillContextMenu(IMenuManager menu) {
196196
menu.add(getAction(ACTION_GOTO_MARKER));
197197
menu.add(new Separator(IDebugUIConstants.EMPTY_BREAKPOINT_GROUP));
198198
menu.add(new Separator(IDebugUIConstants.BREAKPOINT_GROUP));
199+
Separator separator = new Separator(IDebugUIConstants.BREAKPOINT_ADDITIONAL_GROUP);
200+
separator.setVisible(false);
201+
menu.add(separator);
199202
IAction action = getAction(PASTE_ACTION);
200203
if (action != null) {
201204
menu.add(action);

Diff for: debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/IDebugUIConstants.java

+8
Original file line numberDiff line numberDiff line change
@@ -774,6 +774,14 @@ public interface IDebugUIConstants {
774774
*/
775775
String BREAKPOINT_GROUP = "breakpointGroup"; //$NON-NLS-1$
776776

777+
/**
778+
* Identifier for breakpoint operations other than enable/disable succeeding a
779+
* breakpoint group in a menu (value <code>"BreakpointAdditionalGroup"</code>).
780+
*
781+
* @since 3.18
782+
*/
783+
String BREAKPOINT_ADDITIONAL_GROUP = "BreakpointAdditionalGroup"; //$NON-NLS-1$
784+
777785
/**
778786
* Identifier for a "breakpoint group" group in a menu (value <code>"breakpointGroupGroup"</code>).
779787
*

0 commit comments

Comments
 (0)