-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StickyScrolling: Exceptions while opening Java editors from Search view #2678
Closed
iloveeclipse opened this issue
Jan 9, 2025
· 8 comments
· Fixed by #2680 or #2718 · May be fixed by #2719
Closed
StickyScrolling: Exceptions while opening Java editors from Search view #2678
iloveeclipse opened this issue
Jan 9, 2025
· 8 comments
· Fixed by #2680 or #2718 · May be fixed by #2719
Comments
@Christopher-Hermann , @BeckerWdf : could you please check? |
Steps to reproduce for me are:
|
jukzi
changed the title
Errors while opening Java editors from Search view
StickyScrolling: Exceptions while opening Java editors from Search view
Jan 9, 2025
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this issue
Jan 10, 2025
The search view with "reuse editor" enabled sets new source code in the existing editor and causes a resize. In this call, it can happen that the sticky line number exceeds the amount of line in the new source code. In general this is not a problem since the sticky lines will be recalculated afterwards, but to avoid IllegalArgumentException it is checked for this case. Fixes eclipse-platform#2678
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this issue
Jan 10, 2025
The search view with "reuse editor" enabled sets new source code in the existing editor and causes a resize. In this call, it can happen that the sticky line number exceeds the amount of line in the new source code. In general this is not a problem since the sticky lines will be recalculated afterwards, but to avoid IllegalArgumentException it is checked for this case. Fixes eclipse-platform#2678
I observe now worse behavior:
|
I'm using latest SDK 4.35.0.I20250113-1800 |
@Christopher-Hermann : could you please look at the problem? |
Yes, I will have a look. However, it may take a few days due |
To reproduce the IllegalArgumentException:
|
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this issue
Jan 17, 2025
Sticky lines should be shown when the file is opened via search view. Fixes eclipse-platform#2678
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this issue
Jan 17, 2025
The search view with "reuse editor" enabled sets new source code in the existing editor and fires a extPresentation change event. In this call, it can happen that the sticky line number exceeds the amount of line in the new source code. In general this is not a problem since the sticky lines will be recalculated afterwards, but to avoid IllegalArgumentException it is checked for this case. Fixes eclipse-platform#2678
@iloveeclipse Thanks for spotting this issues. I created two PRs to fix it. |
iloveeclipse
pushed a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this issue
Jan 17, 2025
The search view with "reuse editor" enabled sets new source code in the existing editor and fires a extPresentation change event. In this call, it can happen that the sticky line number exceeds the amount of line in the new source code. In general this is not a problem since the sticky lines will be recalculated afterwards, but to avoid IllegalArgumentException it is checked for this case. Fixes eclipse-platform#2678
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this issue
Jan 17, 2025
The search view with "reuse editor" enabled sets new source code in the existing editor and fires a extPresentation change event. In this call, it can happen that the sticky line number exceeds the amount of line in the new source code. In general this is not a problem since the sticky lines will be recalculated afterwards, but to avoid IllegalArgumentException it is checked for this case. Fixes eclipse-platform#2678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've searched for method references and used Search view to navigate ("reuse editors" was on, "sticky lines" limit set to 4).
Sooner or later I've got following exceptions below trying to open next search result in Java editor
Probably regression from #2592
The text was updated successfully, but these errors were encountered: