Adjust selection filling the curve for CTabFolder

When CTabFolder is selected there is a visible gap on top as well as on
the top left where there is a curve (in RCP when theming is disabled).
Also the image was too close to selection highlight which is adjusted
here as well.

Author: ShahzaibIbrahim

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolderRenderer.java

@@ -14,6 +14,8 @@
  *******************************************************************************/
 package org.eclipse.swt.custom;
 
+import java.util.*;
+
 import org.eclipse.swt.*;
 import org.eclipse.swt.graphics.*;
 import org.eclipse.swt.widgets.*;
@@ -1380,10 +1382,23 @@ void drawSelected(int itemIndex, GC gc, Rectangle bounds, int state ) {
 
 				// draw highlight marker of selected tab
 				if (parent.selectionHighlightBarThickness > 0 && parent.simple) {
-					Color previousColor = gc.getBackground();
-					gc.setBackground(item.getDisplay().getSystemColor(parent.shouldHighlight() ? SWT.COLOR_LIST_SELECTION : SWT.COLOR_WIDGET_DISABLED_FOREGROUND));
-					gc.fillRectangle(x + 1 /* outline */, parent.onBottom ? y + height - 1 - parent.selectionHighlightBarThickness : y + 1, width - 2 /*outline*/, parent.selectionHighlightBarThickness);
-					gc.setBackground(previousColor);
+					int thickness = parent.selectionHighlightBarThickness;
+					boolean onBottom = parent.onBottom;
+					boolean highlight = parent.shouldHighlight();
+
+					Color oldBackground = gc.getBackground();
+					Color highlightColor = item.getDisplay().getSystemColor(
+							highlight ? SWT.COLOR_LIST_SELECTION : SWT.COLOR_WIDGET_DISABLED_FOREGROUND);
+					gc.setBackground(highlightColor);
+
+					int bottomY = y + height - 1;
+					int highlightY = onBottom ? bottomY - thickness : thickness + 1;
+
+					int[] shape2 = Arrays.copyOf(shape, shape.length);
+					// Update Y coordinates in shape to apply highlight thickness
+					shape2[1] = shape2[3] = shape2[shape2.length - 1] = shape2[shape2.length - 3] = highlightY;
+					gc.fillPolygon(shape2);
+					gc.setBackground(oldBackground);
 				}
 
 				// draw outline
@@ -1642,7 +1657,7 @@ void drawUnselected(int index, GC gc, Rectangle bounds, int state) {
 				if (imageBounds.width < maxImageWidth) {
 					int imageX = xDraw;
 					int imageHeight = imageBounds.height;
-					int imageY = y + (height - imageHeight) / 2;
+					int imageY = 1 + y + (height - imageHeight) / 2;
 					imageY += parent.onBottom ? -1 : 1;
 					int imageWidth = imageBounds.width * imageHeight / imageBounds.height;
 					gc.drawImage(image, imageX, imageY, imageWidth, imageHeight);