-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of default directory for mixed refs builds #11768
Comments
I'm not sure we want to do this - we had originally decided that default would be the directory for mixed builds. |
Right, using I think @keithc-ca might have some thoughts on this too? |
The plan was to allow the redirector to continue to select other VMs if we have a future experimental build that we want to package in. This doesn't necessarily preclude moving the default VM up a level, but I'm not sure there's any real value to it. |
If no other comments, I think I'll just close this issue. |
It might make a (small?) performance difference removing an extra directory from each of these search paths:
It takes longer to search a directory and fail than it does to succeed. We don't need to eliminate the redirector, so those experiments would still be possible. |
In a regular build, sources are generated into the
default
directory for non-compressed refs build and thecompressedrefs
directory for a compressed refs build.In mixed builds, we currently generate the sources/libs into the
default
directory. However, it's not actually necessary for a directory to be used at all for a mixed build, since sources/libraries don't need to be kept separate. So, the generated libraries can just sit in the parent directory where thecompressedrefs
/default
directories currently sit alongside all the other libraries, i.e.images/jdk/lib
,jdk/lib
.More mixed builds discussion: #8878.
The text was updated successfully, but these errors were encountered: