From b62463718aa3aa098cd86ec651997f732807a809 Mon Sep 17 00:00:00 2001
From: Marvin Philipp Vogel <marvinv@mail.uni-paderborn.de>
Date: Wed, 13 Oct 2021 14:47:56 +0200
Subject: [PATCH 1/4] Improve wizard interface for the task selection page

Signed-off-by: Marvin Philipp Vogel <marvinv@mail.uni-paderborn.de>
---
 .../wizard/TaskSelectionPage.java             | 216 +++++++++++-------
 1 file changed, 133 insertions(+), 83 deletions(-)

diff --git a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
index 3875937a4..97a0184cc 100644
--- a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
+++ b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
@@ -14,7 +14,6 @@
 
 import java.io.File;
 import java.io.FileInputStream;
-import java.io.InputStream;
 import java.net.URI;
 import java.net.URL;
 import java.util.ArrayList;
@@ -25,15 +24,19 @@
 import org.eclipse.jface.wizard.WizardPage;
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.custom.ScrolledComposite;
+import org.eclipse.swt.graphics.Color;
 import org.eclipse.swt.graphics.Font;
 import org.eclipse.swt.graphics.FontData;
 import org.eclipse.swt.graphics.Image;
 import org.eclipse.swt.graphics.Rectangle;
 import org.eclipse.swt.layout.GridData;
 import org.eclipse.swt.layout.GridLayout;
+import org.eclipse.swt.layout.RowData;
+import org.eclipse.swt.layout.RowLayout;
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Event;
+import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Listener;
 import org.eclipse.ui.PlatformUI;
@@ -46,8 +49,9 @@
 
 public class TaskSelectionPage extends WizardPage {
 
-	private Composite container;
-	private Task selectedTask = null;
+	private TaskItemComposite selectedTaskItem = null;
+	private Composite listOfTaskItems; // Row Layout Composite that holds task items composite
+	private List<TaskItemComposite> taskItems = new ArrayList<TaskItemComposite>(); // ArrayList of all tasks item composite
 
 	public TaskSelectionPage() {
 		super(Constants.SELECT_TASK);
@@ -58,76 +62,43 @@ public TaskSelectionPage() {
 
 	@Override
 	public void createControl(final Composite parent) {
-		final List<Task> tasks = TaskJSONReader.getTasks();
 
+		// Make the content able to scroll
 		final ScrolledComposite sc = new ScrolledComposite(parent, SWT.H_SCROLL | SWT.V_SCROLL);
 		sc.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));
 
-		this.container = new Composite(sc, SWT.NONE);
-		this.container.setBounds(10, 10, 450, 200);
-
-		//To display the Help view after clicking the help icon
+		// To display the Help view after clicking the help icon
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(sc, "de.cognicrypt.codegenerator.TaskSelectionHelp");
 
-		final GridLayout gl = new GridLayout(2, false);
-		gl.verticalSpacing = -6;
-		this.container.setLayout(gl);
-
-		new GridData(SWT.FILL, SWT.FILL, false, false, 1, 1);
-		new Label(this.container, SWT.NONE);
-		final Label useCaseDescriptionLabel = new Label(this.container, SWT.WRAP);
-		final GridData gd_selectProjectLabel = new GridData(SWT.FILL, SWT.FILL, false, false, 1, tasks.size() + 1);
-		gd_selectProjectLabel.heightHint = 200;
-		gd_selectProjectLabel.widthHint = 600;
-		useCaseDescriptionLabel.setLayoutData(gd_selectProjectLabel);
-		Font a = useCaseDescriptionLabel.getFont();
-		useCaseDescriptionLabel.setFont(new Font(useCaseDescriptionLabel.getDisplay(), new FontData(a.getFontData()[0].getName(), 12, SWT.None)));
-
-		final List<Button> buttons = new ArrayList<Button>();
-		final List<Image> unclickedImages = new ArrayList<Image>();
-		new Label(this.container, SWT.NONE);
-		for (Task ccTask : tasks) {
-			final Image taskImage = loadImage(ccTask.getImage());
-			unclickedImages.add(taskImage);
-
-			final Button taskButton = createImageButton(this.container, taskImage, ccTask.getDescription());
-			buttons.add(taskButton);
+		// listOfTaskItems will hold the selection items for all tasks
+		// it is attached in the ScrolledComposite
+		this.listOfTaskItems = new Composite(sc, SWT.NONE);
+		this.listOfTaskItems.setBounds(10, 10, 400, 200);
+		
+		// Task items are displayed as a list in the listOfTaskItems
+		final RowLayout rl = new RowLayout(SWT.VERTICAL);
+		this.listOfTaskItems.setLayout(rl);
+		
+		// add tasks items to listOfTaskItems
+		for (Task ccTask: TaskJSONReader.getTasks()) {
+			taskItems.add(new TaskItemComposite(this.listOfTaskItems, ccTask));
 		}
-		buttons.stream().forEach(e -> e.addListener(SWT.Selection, new SelectionButtonListener(buttons, unclickedImages, tasks, useCaseDescriptionLabel)));
-		buttons.get(0).notifyListeners(SWT.Selection, new Event());
-
-		setControl(this.container);
-		new Label(this.container, SWT.NONE);
-		new Label(this.container, SWT.NONE);
-
-		sc.setContent(this.container);
+		
+		sc.setContent(this.listOfTaskItems);
 		sc.setExpandHorizontal(true);
 		sc.setExpandVertical(true);
-		sc.setMinSize(this.container.computeSize(SWT.DEFAULT, SWT.DEFAULT));
+		sc.setMinSize(this.listOfTaskItems.computeSize(SWT.DEFAULT, SWT.DEFAULT));
 		setControl(sc);
 	}
 
-	public Task getSelectedTask() {
-		return this.selectedTask;
-	}
-
 	@Override
 	public void setVisible(final boolean visible) {
 		super.setVisible(visible);
 		if (visible) {
-			this.container.setFocus();
+			this.listOfTaskItems.setFocus();
 		}
 	}
 
-	private Button createImageButton(final Composite container, final Image startImage, String taskName) {
-		final Button imageButton = new Button(container, SWT.WRAP | SWT.TOGGLE);
-		final Rectangle bounds = startImage.getBounds();
-		imageButton.setSize(bounds.width, bounds.height);
-		imageButton.setImage(startImage);
-		imageButton.setToolTipText(taskName);
-		return imageButton;
-	}
-
 	private Image loadImage(final String image) {
 		try {
 			final Bundle bundle = Platform.getBundle(Activator.PLUGIN_ID);
@@ -150,42 +121,121 @@ private Image loadImage(final String image) {
 		}
 
 		return null;
+		
+	}
+	
+	/**
+	 * A single choice selection on all task items. When calling this method, only one task item will be selected.
+	 */
+	public void selectTaskItem(TaskItemComposite taskItem) {
+		// unselect other task items
+		for(TaskItemComposite notSelectedTaskItem: this.taskItems) {
+			if(notSelectedTaskItem != taskItem) {
+				notSelectedTaskItem.unselect();
+			}
+		}
+		taskItem.select();
+		TaskSelectionPage.this.selectedTaskItem = taskItem;
+		
+		setPageComplete(true); // next button on wizard is now clickable
+	}
+	
+	public Task getSelectedTask() {
+		return this.selectedTaskItem.getTask();
+	}
+	
+	
+	/**
+	 * This class will append a row with a image button, title and description for a task.
+	 * If any Element in this Composite is pressed, a ItemClickListener is triggered.
+	 * @param listOfTaskItems is the list, where to add the item
+	 * @param task to add in the row
+	 */
+	class TaskItemComposite extends Composite {
+		
+		private Task task;
+		private Button button;
+
+		TaskItemComposite(final Composite listOfTaskItems, Task task) {
+			
+			// listOfTaskItems with 2 columns
+			super(listOfTaskItems, SWT.FILL);
+			this.setLayout(new GridLayout(2, false));
+			
+			// First column gets a button with the image
+			this.button = new Button(this, SWT.TOGGLE);
+			this.button.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false));
+			final Image taskImage = loadImage(task.getImage());
+			if(taskImage == null) {
+				throw new IllegalArgumentException("Missing Image for Task: " + task.getName());
+			}
+			final Rectangle bounds = taskImage.getBounds();
+			this.button.setSize(bounds.width, bounds.height);
+			this.button.setImage(taskImage);
+			
+			// Second column gets group with title and description
+			final Group descr = new Group(this, SWT.FILL);
+			descr.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false));
+			descr.setLayout(new RowLayout(SWT.VERTICAL));
+			
+			// title
+			final Label title = new Label(descr, SWT.WRAP);
+			title.setText(task.getDescription());
+			final Font boldFont = new Font( title.getDisplay(), new FontData( "Arial", 12, SWT.BOLD ) );
+			title.setFont(boldFont);
+			
+			// description
+			final Label taskdescr = new Label(descr, SWT.WRAP);
+			final Color taskdescrColor = new Color(taskdescr.getDisplay(), 100, 100, 100);
+			final Font largeFont = new Font( descr.getDisplay(), new FontData( "Arial", 14, SWT.NONE ) );
+			taskdescr.setFont(largeFont);
+			taskdescr.setForeground(taskdescrColor);
+			RowData rd_taskdescr = new RowData();
+			rd_taskdescr.width = 400;
+			taskdescr.setLayoutData(rd_taskdescr);
+			taskdescr.setText(task.getTaskDescription());
+			taskdescr.pack();
+			
+			this.task = task;
+			
+			// click listener to all elements
+			// TODO: one Listener for the whole Composite would be nice
+			ItemClickListener listener = new ItemClickListener(this);
+			this.addListener(SWT.MouseUp, listener);
+			this.button.addListener(SWT.MouseUp, listener);
+			descr.addListener(SWT.MouseUp, listener);
+			title.addListener(SWT.MouseUp, listener);
+			taskdescr.addListener(SWT.MouseUp, listener);
+		}
+		
+		public void select() {
+			this.button.setSelection(true);
+		}
+		
+		public void unselect() {
+			this.button.setSelection(false);
+		}
+		
+		public Task getTask() {
+			return this.task;
+		}
+		
 	}
 
-	class SelectionButtonListener implements Listener {
-
-		private final List<Button> buttons;
-		private final List<Image> buttonImages;
-		private final List<Task> tasks;
-
-		private final Label targetLabel;
+	/**
+	 * This class listens to clicks on task item components.
+	 */
+	class ItemClickListener implements Listener {
 
-		public SelectionButtonListener(final List<Button> buttons, final List<Image> buttonImages, final List<Task> tasks, final Label targetLabel) {
-			if (buttons.size() != buttonImages.size() || buttons.size() != tasks.size()) {
-				throw new IllegalArgumentException("All arrays are required to have the same length." + "If not it indicates an incomplete setup for buttons and their images");
-			}
+		private final TaskItemComposite taskItem;
 
-			this.buttons = buttons;
-			this.buttonImages = buttonImages;
-			this.tasks = tasks;
-			this.targetLabel = targetLabel;
+		public ItemClickListener(TaskItemComposite taskItem) {
+			this.taskItem = taskItem;
 		}
 
 		@Override
-		public void handleEvent(final Event event) {
-			final Button eventButton = (Button) event.widget;
-			for (int i = 0; i < this.buttons.size(); i++) {
-				final Button curIterationButton = this.buttons.get(i);
-				if (eventButton.equals(curIterationButton)) {
-					TaskSelectionPage.this.selectedTask = this.tasks.get(i);
-					curIterationButton.setSelection(true);
-					this.targetLabel.setText(TaskSelectionPage.this.selectedTask.getTaskDescription());
-					setPageComplete(true);
-				} else {
-					curIterationButton.setSelection(false);
-					curIterationButton.setImage(this.buttonImages.get(i));
-				}
-			}
+		public void handleEvent(Event event) {
+			selectTaskItem(this.taskItem);
 		}
 	}
 }

From 04c1bae8d8cd5b953093e6ae7661f9ccfc05b383 Mon Sep 17 00:00:00 2001
From: Marvin Philipp Vogel <marvinv@mail.uni-paderborn.de>
Date: Mon, 18 Oct 2021 12:59:10 +0200
Subject: [PATCH 2/4] add the button into the group and make them to radio
 buttons

---
 .../wizard/TaskSelectionPage.java             | 22 ++++++++++++-------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
index 97a0184cc..be0377fbd 100644
--- a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
+++ b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
@@ -27,6 +27,7 @@
 import org.eclipse.swt.graphics.Color;
 import org.eclipse.swt.graphics.Font;
 import org.eclipse.swt.graphics.FontData;
+import org.eclipse.swt.graphics.GC;
 import org.eclipse.swt.graphics.Image;
 import org.eclipse.swt.graphics.Rectangle;
 import org.eclipse.swt.layout.GridData;
@@ -35,6 +36,7 @@
 import org.eclipse.swt.layout.RowLayout;
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
+import org.eclipse.swt.widgets.Display;
 import org.eclipse.swt.widgets.Event;
 import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Label;
@@ -52,7 +54,7 @@ public class TaskSelectionPage extends WizardPage {
 	private TaskItemComposite selectedTaskItem = null;
 	private Composite listOfTaskItems; // Row Layout Composite that holds task items composite
 	private List<TaskItemComposite> taskItems = new ArrayList<TaskItemComposite>(); // ArrayList of all tasks item composite
-
+	
 	public TaskSelectionPage() {
 		super(Constants.SELECT_TASK);
 		setTitle(Constants.TASK_LIST);
@@ -77,6 +79,8 @@ public void createControl(final Composite parent) {
 		
 		// Task items are displayed as a list in the listOfTaskItems
 		final RowLayout rl = new RowLayout(SWT.VERTICAL);
+		rl.spacing = 5;
+		rl.justify = true;
 		this.listOfTaskItems.setLayout(rl);
 		
 		// add tasks items to listOfTaskItems
@@ -158,12 +162,14 @@ class TaskItemComposite extends Composite {
 
 		TaskItemComposite(final Composite listOfTaskItems, Task task) {
 			
-			// listOfTaskItems with 2 columns
+			// listOfTaskItems is filled with a Group, which has a two row grid layout.
 			super(listOfTaskItems, SWT.FILL);
-			this.setLayout(new GridLayout(2, false));
+			this.setLayout(new GridLayout(1, false));
+			final Group group = new Group(this, SWT.FILL | SWT.SHADOW_ETCHED_OUT);
+			group.setLayout(new GridLayout(2, false));
 			
-			// First column gets a button with the image
-			this.button = new Button(this, SWT.TOGGLE);
+			// First column gets a radio button with the image
+			this.button = new Button(group, SWT.TOGGLE | SWT.RADIO);
 			this.button.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false));
 			final Image taskImage = loadImage(task.getImage());
 			if(taskImage == null) {
@@ -174,7 +180,7 @@ class TaskItemComposite extends Composite {
 			this.button.setImage(taskImage);
 			
 			// Second column gets group with title and description
-			final Group descr = new Group(this, SWT.FILL);
+			final Composite descr = new Composite(group, SWT.FILL);
 			descr.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false));
 			descr.setLayout(new RowLayout(SWT.VERTICAL));
 			
@@ -186,10 +192,10 @@ class TaskItemComposite extends Composite {
 			
 			// description
 			final Label taskdescr = new Label(descr, SWT.WRAP);
-			final Color taskdescrColor = new Color(taskdescr.getDisplay(), 100, 100, 100);
 			final Font largeFont = new Font( descr.getDisplay(), new FontData( "Arial", 14, SWT.NONE ) );
 			taskdescr.setFont(largeFont);
-			taskdescr.setForeground(taskdescrColor);
+			final Color gray = Display.getCurrent().getSystemColor(SWT.COLOR_DARK_GRAY);
+			taskdescr.setForeground(gray);
 			RowData rd_taskdescr = new RowData();
 			rd_taskdescr.width = 400;
 			taskdescr.setLayoutData(rd_taskdescr);

From 5c55a9428cd75136dcd3b21f288c7c3c374efe8a Mon Sep 17 00:00:00 2001
From: Marvin Philipp Vogel <marvinv@mail.uni-paderborn.de>
Date: Mon, 18 Oct 2021 13:55:54 +0200
Subject: [PATCH 3/4] set scrollbar always visible and add dispose listener to
 fix fonts and image resource leaks

---
 .../wizard/TaskSelectionPage.java             | 23 +++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
index be0377fbd..966d08972 100644
--- a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
+++ b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
@@ -24,10 +24,11 @@
 import org.eclipse.jface.wizard.WizardPage;
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.custom.ScrolledComposite;
+import org.eclipse.swt.events.DisposeEvent;
+import org.eclipse.swt.events.DisposeListener;
 import org.eclipse.swt.graphics.Color;
 import org.eclipse.swt.graphics.Font;
 import org.eclipse.swt.graphics.FontData;
-import org.eclipse.swt.graphics.GC;
 import org.eclipse.swt.graphics.Image;
 import org.eclipse.swt.graphics.Rectangle;
 import org.eclipse.swt.layout.GridData;
@@ -79,8 +80,6 @@ public void createControl(final Composite parent) {
 		
 		// Task items are displayed as a list in the listOfTaskItems
 		final RowLayout rl = new RowLayout(SWT.VERTICAL);
-		rl.spacing = 5;
-		rl.justify = true;
 		this.listOfTaskItems.setLayout(rl);
 		
 		// add tasks items to listOfTaskItems
@@ -91,8 +90,9 @@ public void createControl(final Composite parent) {
 		sc.setContent(this.listOfTaskItems);
 		sc.setExpandHorizontal(true);
 		sc.setExpandVertical(true);
+		sc.setAlwaysShowScrollBars(true);
 		sc.setMinSize(this.listOfTaskItems.computeSize(SWT.DEFAULT, SWT.DEFAULT));
-		setControl(sc);
+		this.setControl(sc);
 	}
 
 	@Override
@@ -165,6 +165,7 @@ class TaskItemComposite extends Composite {
 			// listOfTaskItems is filled with a Group, which has a two row grid layout.
 			super(listOfTaskItems, SWT.FILL);
 			this.setLayout(new GridLayout(1, false));
+			//this.setLayoutData(new RowData(SWT.FILL, SWT.DEFAULT));
 			final Group group = new Group(this, SWT.FILL | SWT.SHADOW_ETCHED_OUT);
 			group.setLayout(new GridLayout(2, false));
 			
@@ -194,6 +195,7 @@ class TaskItemComposite extends Composite {
 			final Label taskdescr = new Label(descr, SWT.WRAP);
 			final Font largeFont = new Font( descr.getDisplay(), new FontData( "Arial", 14, SWT.NONE ) );
 			taskdescr.setFont(largeFont);
+			
 			final Color gray = Display.getCurrent().getSystemColor(SWT.COLOR_DARK_GRAY);
 			taskdescr.setForeground(gray);
 			RowData rd_taskdescr = new RowData();
@@ -212,6 +214,19 @@ class TaskItemComposite extends Composite {
 			descr.addListener(SWT.MouseUp, listener);
 			title.addListener(SWT.MouseUp, listener);
 			taskdescr.addListener(SWT.MouseUp, listener);
+			
+			// add dispose listener (best practice: https://www.eclipse.org/articles/swt-design-2/swt-design-2.html)
+			this.addDisposeListener(new DisposeListener() {
+				
+				@Override
+				public void widgetDisposed(DisposeEvent event) {
+					boldFont.dispose();
+					largeFont.dispose();
+					taskImage.dispose();
+				}
+			});
+			
+			
 		}
 		
 		public void select() {

From 2966df209ac3379332eeec7b670118ec2c853047 Mon Sep 17 00:00:00 2001
From: Marvin Philipp Vogel <marvinv@mail.uni-paderborn.de>
Date: Sat, 23 Oct 2021 14:54:31 +0200
Subject: [PATCH 4/4] make text wrap and fit task items width to window width

---
 .../wizard/CogniCryptWizardDialog.java        |  3 +-
 .../wizard/TaskSelectionPage.java             | 33 +++++++++----------
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/CogniCryptWizardDialog.java b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/CogniCryptWizardDialog.java
index a7ee0659d..7f9e7c2c3 100644
--- a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/CogniCryptWizardDialog.java
+++ b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/CogniCryptWizardDialog.java
@@ -13,6 +13,7 @@
 import org.eclipse.jface.dialogs.IDialogConstants;
 import org.eclipse.jface.wizard.IWizard;
 import org.eclipse.jface.wizard.WizardDialog;
+import org.eclipse.swt.graphics.Point;
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Shell;
@@ -21,6 +22,7 @@ public class CogniCryptWizardDialog extends WizardDialog {
 
 	public CogniCryptWizardDialog(final Shell parentShell, final IWizard newWizard) {
 		super(parentShell, newWizard);
+		this.setPageSize(new Point(400, 600));
 	}
 
 	@Override
@@ -29,5 +31,4 @@ protected void createButtonsForButtonBar(final Composite parent) {
 		final Button finishButton = getButton(IDialogConstants.FINISH_ID);
 		finishButton.setText("Generate");
 	}
-
 }
diff --git a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
index 966d08972..caf90cbc9 100644
--- a/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
+++ b/plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/TaskSelectionPage.java
@@ -33,8 +33,6 @@
 import org.eclipse.swt.graphics.Rectangle;
 import org.eclipse.swt.layout.GridData;
 import org.eclipse.swt.layout.GridLayout;
-import org.eclipse.swt.layout.RowData;
-import org.eclipse.swt.layout.RowLayout;
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Display;
@@ -67,8 +65,8 @@ public TaskSelectionPage() {
 	public void createControl(final Composite parent) {
 
 		// Make the content able to scroll
-		final ScrolledComposite sc = new ScrolledComposite(parent, SWT.H_SCROLL | SWT.V_SCROLL);
-		sc.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));
+		final ScrolledComposite sc = new ScrolledComposite(parent, SWT.V_SCROLL);
+		sc.setLayoutData(new GridData(GridData.FILL, GridData.FILL, true, true));
 
 		// To display the Help view after clicking the help icon
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(sc, "de.cognicrypt.codegenerator.TaskSelectionHelp");
@@ -76,11 +74,11 @@ public void createControl(final Composite parent) {
 		// listOfTaskItems will hold the selection items for all tasks
 		// it is attached in the ScrolledComposite
 		this.listOfTaskItems = new Composite(sc, SWT.NONE);
-		this.listOfTaskItems.setBounds(10, 10, 400, 200);
 		
 		// Task items are displayed as a list in the listOfTaskItems
-		final RowLayout rl = new RowLayout(SWT.VERTICAL);
+		final GridLayout rl = new GridLayout(1, false);
 		this.listOfTaskItems.setLayout(rl);
+		this.listOfTaskItems.setLayoutData(new GridData(GridData.FILL, GridData.BEGINNING, true, false));
 		
 		// add tasks items to listOfTaskItems
 		for (Task ccTask: TaskJSONReader.getTasks()) {
@@ -91,7 +89,9 @@ public void createControl(final Composite parent) {
 		sc.setExpandHorizontal(true);
 		sc.setExpandVertical(true);
 		sc.setAlwaysShowScrollBars(true);
-		sc.setMinSize(this.listOfTaskItems.computeSize(SWT.DEFAULT, SWT.DEFAULT));
+		sc.addListener( SWT.Resize, event -> {
+			 sc.setMinSize(this.listOfTaskItems.computeSize( getShell().getClientArea().width - sc.getVerticalBar().getSize().x, SWT.DEFAULT));
+			} );
 		this.setControl(sc);
 	}
 
@@ -163,15 +163,16 @@ class TaskItemComposite extends Composite {
 		TaskItemComposite(final Composite listOfTaskItems, Task task) {
 			
 			// listOfTaskItems is filled with a Group, which has a two row grid layout.
-			super(listOfTaskItems, SWT.FILL);
+			super(listOfTaskItems, SWT.NONE);
 			this.setLayout(new GridLayout(1, false));
-			//this.setLayoutData(new RowData(SWT.FILL, SWT.DEFAULT));
-			final Group group = new Group(this, SWT.FILL | SWT.SHADOW_ETCHED_OUT);
+			this.setLayoutData(new GridData(GridData.FILL, GridData.FILL, true, false));
+			final Group group = new Group(this, SWT.SHADOW_ETCHED_OUT);
 			group.setLayout(new GridLayout(2, false));
+			group.setLayoutData(new GridData(GridData.FILL, GridData.FILL, true, false));
 			
 			// First column gets a radio button with the image
 			this.button = new Button(group, SWT.TOGGLE | SWT.RADIO);
-			this.button.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false));
+			this.button.setLayoutData(new GridData(GridData.BEGINNING, GridData.CENTER, false, false));
 			final Image taskImage = loadImage(task.getImage());
 			if(taskImage == null) {
 				throw new IllegalArgumentException("Missing Image for Task: " + task.getName());
@@ -181,9 +182,9 @@ class TaskItemComposite extends Composite {
 			this.button.setImage(taskImage);
 			
 			// Second column gets group with title and description
-			final Composite descr = new Composite(group, SWT.FILL);
-			descr.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false));
-			descr.setLayout(new RowLayout(SWT.VERTICAL));
+			final Composite descr = new Composite(group, SWT.NONE);
+			descr.setLayoutData(new GridData(GridData.FILL, GridData.FILL, true, false));
+			descr.setLayout(new GridLayout(1, false));
 			
 			// title
 			final Label title = new Label(descr, SWT.WRAP);
@@ -198,10 +199,8 @@ class TaskItemComposite extends Composite {
 			
 			final Color gray = Display.getCurrent().getSystemColor(SWT.COLOR_DARK_GRAY);
 			taskdescr.setForeground(gray);
-			RowData rd_taskdescr = new RowData();
-			rd_taskdescr.width = 400;
-			taskdescr.setLayoutData(rd_taskdescr);
 			taskdescr.setText(task.getTaskDescription());
+			taskdescr.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
 			taskdescr.pack();
 			
 			this.task = task;