Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

effective_sample(): returns tail ESS for brms models #705

Merged
merged 16 commits into from
Mar 16, 2025
Merged

Conversation

DominiqueMakowski
Copy link
Member

@DominiqueMakowski DominiqueMakowski commented Mar 15, 2025

Fixes #704

@DominiqueMakowski
Copy link
Member Author

Didn't find another way to pull ESS than using posterior

@strengejacke
Copy link
Member

I think we also need parameters filtering

@strengejacke
Copy link
Member

I think we also need parameters filtering

Oh, it's already there I saw.

@strengejacke
Copy link
Member

There are a lot of RD-files changed, but that's no problem right now. You said you'd prefer "simple" argument options, so I just kept the main option. We can now leave all the checks for the argument to the insight functions, and furthermore, we thereby also allow all options that are supported in insight (which might have been more there than here in bayestestR).

Furthermore, posterior also works for stanreg, so the functions simply differ in their default options, but then the stanreg method just calls the brms method.

We can then later revise all the other bayestestR methods, and only have one option for the effects and the component argument, and again do all the checks for valid options in insight, this simplifies the code and the docs.

Copy link

codecov bot commented Mar 16, 2025

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 54.51%. Comparing base (22b9801) to head (87b76cd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/effective_sample.R 59.09% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
- Coverage   54.56%   54.51%   -0.05%     
==========================================
  Files          64       64              
  Lines        5947     5932      -15     
==========================================
- Hits         3245     3234      -11     
+ Misses       2702     2698       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@strengejacke strengejacke merged commit b8b02db into main Mar 16, 2025
12 of 25 checks passed
@strengejacke strengejacke deleted the ess_tail branch March 16, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe_posterior(): make it possible to return Bulk and tail ess
2 participants