-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
effective_sample(): returns tail ESS for brms models #705
Conversation
Didn't find another way to pull ESS than using |
I think we also need parameters filtering |
Oh, it's already there I saw. |
There are a lot of RD-files changed, but that's no problem right now. You said you'd prefer "simple" argument options, so I just kept the main option. We can now leave all the checks for the argument to the insight functions, and furthermore, we thereby also allow all options that are supported in insight (which might have been more there than here in bayestestR). Furthermore, posterior also works for stanreg, so the functions simply differ in their default options, but then the stanreg method just calls the brms method. We can then later revise all the other bayestestR methods, and only have one option for the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
- Coverage 54.56% 54.51% -0.05%
==========================================
Files 64 64
Lines 5947 5932 -15
==========================================
- Hits 3245 3234 -11
+ Misses 2702 2698 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #704