Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort/black to pyRTE #76

Open
tcmetzger opened this issue Jan 8, 2025 · 3 comments
Open

Add isort/black to pyRTE #76

tcmetzger opened this issue Jan 8, 2025 · 3 comments
Assignees
Milestone

Comments

@tcmetzger
Copy link
Collaborator

We are already formatting the pyRTE code with black and isort locally before committing, but we should formalize this as pre-commit hook and Github action.

@tcmetzger tcmetzger converted this from a draft issue Jan 8, 2025
@tcmetzger tcmetzger added this to the Phase 2 milestone Jan 8, 2025
@tcmetzger
Copy link
Collaborator Author

@sehnem Feel free to pull in @giancastro for help on this one!

@sehnem sehnem moved this from To Do to In progress in pyRTE Phase 2 Jan 12, 2025
@RobertPincus
Copy link
Member

Seems like this is completed?

@sehnem
Copy link
Collaborator

sehnem commented Jan 14, 2025

Yes, it is @RobertPincus and @tcmetzger, the only thing that is not final is that I added some exclusion to the docstrings checks for flake8, but I should remove it when the clouds are ready.

@sehnem sehnem moved this from In progress to In review in pyRTE Phase 2 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

No branches or pull requests

3 participants