Skip to content

Commit 2c1973c

Browse files
author
Ernesto Perez Amigo
committed
Fixed bug in the queryset_factory function because it did not always return a queryset
1 parent 78ab2e4 commit 2c1973c

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

graphene_django_extras/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from .pagination import LimitOffsetGraphqlPagination, PageGraphqlPagination, CursorGraphqlPagination
88
from .types import DjangoObjectType, DjangoInputObjectType, DjangoListObjectType
99

10-
VERSION = (0, 0, 1, 'beta', 9)
10+
VERSION = (0, 0, 1, 'beta', 10)
1111

1212
__version__ = get_version(VERSION)
1313

graphene_django_extras/fields.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def list_resolver1(manager, filterset_class, filtering_args, root, info, **kwarg
8787
qs = find_field(info.field_asts[0], root._prefetched_objects_cache)
8888

8989
if not qs:
90-
qs = queryset_factory(manager, info.field_asts, info.fragments, **kwargs).get_queryset()
90+
qs = queryset_factory(manager, info.field_asts, info.fragments, **kwargs)
9191
qs = filterset_class(data=filter_kwargs, queryset=qs).qs
9292

9393
if root and is_valid_django_model(root._meta.model):
@@ -117,7 +117,7 @@ def list_resolver(manager, filterset_class, filtering_args, root, info, **kwargs
117117
qs = None
118118

119119
if not qs:
120-
qs = queryset_factory(manager, info.field_asts, info.fragments, **kwargs).get_queryset()
120+
qs = queryset_factory(manager, info.field_asts, info.fragments, **kwargs)
121121
qs = filterset_class(data=filter_kwargs, queryset=qs).qs
122122

123123
if root and is_valid_django_model(root._meta.model):
@@ -173,7 +173,7 @@ def model(self):
173173
def list_resolver(self, manager, filterset_class, filtering_args,
174174
root, info, **kwargs):
175175

176-
qs = queryset_factory(manager, info.field_asts, info.fragments, **kwargs).get_queryset()
176+
qs = queryset_factory(manager, info.field_asts, info.fragments, **kwargs)
177177
qs = filterset_class(data=filter_kwargs, queryset=qs).qs
178178

179179
if root and is_valid_django_model(root._meta.model):
@@ -229,7 +229,7 @@ def model(self):
229229

230230
def list_resolver(self, manager, filterset_class, filtering_args, root, info, **kwargs):
231231

232-
qs = queryset_factory(manager, info.field_asts, info.fragments, **kwargs).get_queryset()
232+
qs = queryset_factory(manager, info.field_asts, info.fragments, **kwargs)
233233

234234
filter_kwargs = {k: v for k, v in kwargs.items() if k in filtering_args}
235235

graphene_django_extras/utils.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,4 +168,4 @@ def queryset_factory(manager, fields_asts=None, fragments=None, **kwargs):
168168
return manager.prefetch_related(*prefetch_related)
169169
elif select_related and not prefetch_related:
170170
return manager.select_related(*select_related)
171-
return manager
171+
return manager.get_queryset()

0 commit comments

Comments
 (0)