Just note, issue with canonical URL for different frontpage

[Jimmi08]

Just note, because I don't suppose somebody will look at so specific case.

I have set custom frontpage file (with class2.php) included. I noticed that I am getting debug error about duplicate attempt to set canonical URL.

If I use directly index.php , it is ok.
If I use directly customfile.php, it is ok
But if my URL is homepage (frontpage, just mysite.com) there is a problem.

The first call is here:

Array
(
    [file] => mysite.com\index.php
    [line] => 65
    [function] => run
    [class] => e_url
    [type] => ->
)

Second one:

Debug: More than one canonical was attempted. This was ignored:
Array
(
    [file] => mysite.com\ehandlers\application.php
    [line] => 3170
    [function] => actionIndex
    [class] => core_index_index_controller
    [type] => ->
)

Of course, I wasn't able to detect source of problem this way because I am not familiar with this topic.

So I checked calls of frontpage prefs/detection.
I notice this check in class2.php

$fpUrl = str_replace(SITEURL, '', rtrim(e_REQUEST_URL, '?/'));
$fpPref = e107::getFrontpage();
 
if($fpUrl === $fpPref)
{
	e107::canonical('_SITEURL_');
}
unset($fpUrl, $fpPref);

and this one in application.php run method

		if(empty($this->_request)) // likely 'index.php' ie. the home page.
		{
			$this->_request = e107::getFrontPage();
			e107::canonical('_SITEURL_');
		}

The second one is missing a check $fpUrl === $fpPref

After adding it there, the problem was solved.
This way:

		if(empty($this->_request)) // likely 'index.php' ie. the home page.
		{
			$this->_request = e107::getFrontPage();
			//e107::canonical('_SITEURL_');

			$fpUrl = str_replace(SITEURL, '', rtrim(e_REQUEST_URL, '?/'));
			$fpPref = $this->_request;

			if ($fpUrl === $fpPref)
			{
				e107::canonical('_SITEURL_');
			}
			unset($fpUrl, $fpPref);

		} 

Maybe this helps somebody.