feat: flattened tool call schema#756
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Coverage Report •
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
added 2 commits
June 1, 2026 02:03
mykhailobuleshnyi
added
the
run-integration-tests-with-creds
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 56d6b05. Configure here.
mykhailobuleshnyi
added
run-integration-tests-with-creds
olbychos
reviewed
Jun 1, 2026
Contributor
olbychos
left a comment
olbychos
left a comment
There was a problem hiding this comment.
Overall looks solid. Let’s consider better patterns and rely on tests.
maksymbuleshnyi
approved these changes
Jun 1, 2026
tyaroshko
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Changes the FC contract (schemas, parsing, and streaming deltas) across the agent pipeline; consumers expecting nested
action_inputin streamed or parsed payloads need to adapt, though runtime unwraps the old shape.Overview
This PR flattens function-calling tool arguments:
thoughtand each tool parameter are top-level fields in the LLM schema and wire JSON, replacing the nestedaction_inputwrapper.ToolCallArguments.to_action_input()still unwraps the legacy nested shape when the model emits onlythought+action_input.Streaming adds
JSONInnerThoughtsExtractorand rewires FC handling sothoughtstreams as REASONING and the remaining JSON (withoutthought) as TOOL_INPUT, with optionalfc_wait_for_first_keyordering and an end-of-stream fallback whenthoughtis missing.provide_final_answerstill uses the existing JSON-field path.Schema generation puts
thoughtfirst, merges tool properties at the root, and relaxes strict/open rules forextra="allow"tools. ThinkingTool usesreflection(withthoughtas an alias) so it does not collide with agent-levelthought. Prompts, tests, and a live OpenAI callback test cover the new behavior.Reviewed by Cursor Bugbot for commit dd37974. Bugbot is set up for automated code reviews on this repo. Configure here.