roller reports tx failure, while it actually passed

[mtsitrin]

auth_info:
  fee:
    amount:
    - amount: "10000000000000000"
      denom: adym
    gas_limit: "424119"
    granter: ""
    payer: ""
  signer_infos: []
  tip: null
body:
  extension_options: []
  memo: ""
  messages:
  - '@type': /dymensionxyz.dymension.sequencer.MsgCreateSequencer
    bond:
      amount: "100000000000000000000"
      denom: adym
    creator: dym1ywmwjjw4kjqlpq9fzgtf0ksyl5cntzkcn6wtzm
    dymintPubKey:
      '@type': /cosmos.crypto.ed25519.PubKey
      key: jEdgUr4x5LMo+ZQBJX5FlPBW04bbLjeZsz7blAu4Bg4=
    metadata:
      contact_details:
        telegram: ""
        website: ""
        x: ""
      details: ""
      evm_rpcs: []
      explorer_url: ""
      extra_data: null
      fee_denom: null
      gas_price: 1000000000.000000000000000000ibc/B2D1F56D24C64E601B2476993E3A9BC33B2138D04AA4480C9026DD4A65F00BF6
      genesis_urls: []
      moniker: ""
      p2p_seeds: []
      rest_api_urls:
      - https://rest.midym.team.rollapp.network:443
      rpcs:
      - https://rpc.midym.team.rollapp.network:443
      snapshots: []
    reward_addr: dym1ctfg2cy6sfhh8w6dvpl06ae097vzwrn4rm25mz
    rollapp_id: wasmkasdder_697931-1
    whitelisted_relayers: []
  non_critical_extension_options: []
  timeout_height: "0"
signatures: []
this transaction is going to register your sequencer with 100dym bond. do you want to continue? [y/N]: Yes
  ERROR   failed to register sequencer:  command execution failed: exit status 1

https://bb.dym.fyi/tx/0463626B93499F34ED33FB31526816DD50E08D04DD88C587325553B0136DB504

[danwt]

Investigation Report

Summary

Issue: roller reports transaction failure when the transaction actually succeeded on-chain

Root Cause Analysis

Investigation identified multiple compounding bugs in roller's transaction handling:

1. Invalid WebSocket URLs (HIGH severity)

• Location: cmd/consts/dymension.go
• The WsUrl fields are configured with HTTPS URLs instead of WebSocket URLs:

  WsUrl: "https://dymension.api.onfinality.io:443/public-ws"  // Should be wss://

• This causes WebSocket-based transaction monitoring to fail immediately

2. Race Condition in Transaction Monitoring (HIGH severity)

• Location: utils/tx/tx.go:80-116
• When both monitoring methods (WebSocket + HTTP API) are spawned:
  • WebSocket fails immediately (due to wrong URL scheme)
  • HTTP API polling may not find the tx yet (not enough blocks)
  • Result: Returns "timeout" or "all monitoring methods failed" error
• But the transaction actually succeeded on-chain

3. Channel Logic Bug (MEDIUM severity)

• Location: utils/tx/tx.go:109
• The condition if resultChan == nil && errChan == nil can never be true
• Channels don't become nil when closed in Go

4. Incomplete Transaction Validation (MEDIUM severity)

• Location: cmd/tx/tx_utils/tx_utils.go:26-39
• CheckTxYamlStdOut() only validates mempool acceptance (immediate broadcast response)
• Does NOT validate on-chain success

The Bug Sequence

1. User runs sequencer registration
2. TX broadcasts successfully (accepted to mempool, code=0) ✓
3. CheckTxYamlStdOut() passes ✓
4. MonitorTransaction() called with HTTPS URL ✗
   - WebSocket monitor fails immediately (HTTPS not WS)
   - API monitor polls but tx not confirmed yet
   - Timeout/error returned
5. CLI reports "failed to register sequencer" ✗
6. TX actually succeeds on-chain ✓

Impact

• Users see false failure messages
• May cause users to retry, leading to duplicate registration attempts
• Erodes trust in the CLI tool

Recommended Fixes

Priority	Fix	Files
P0	Fix WebSocket URLs (use wss:// scheme)	cmd/consts/dymension.go
P1	Fix channel logic in MonitorTransaction	utils/tx/tx.go
P1	Add proper fallback when WebSocket fails	utils/tx/tx.go
P2	Improve error messages to suggest checking explorer	utils/sequencer/sequencer.go