feat: move suggest PR desc to notify workflow

Author: catngh

apps/agent/src/constants/discord.ts

@@ -2,4 +2,5 @@ export const DISCORD_GITHUB_MAP = {
   zlatanpham: '790170208228212766',
   vdhieu: '797044001579597846',
   'R-Jim': '797044001579597846',
+  catngh: '319132138849173505',
 }

apps/agent/src/mastra/index.ts

@@ -4,7 +4,6 @@ import {
   notifyDeveloperPRRequestWorkflow,
   sendTodayPRListToDiscordWorkflow,
   notifyDeveloperAboutPRStatus,
-  suggestPRsDescription,
 } from './workflows'
 import { githubAgent } from './agents'
 
@@ -13,7 +12,6 @@ export const mastra = new Mastra({
     notifyDeveloperPRRequestWorkflow,
     sendTodayPRListToDiscordWorkflow,
     notifyDeveloperAboutPRStatus,
-    suggestPRsDescription,
   },
   agents: {
     githubAgent,

apps/agent/src/mastra/workflows/github-notify-developer-about-pr-status.ts

@@ -5,6 +5,7 @@ import { discordClient } from '../../lib/discord'
 import { groupBy } from '../../utils/array'
 import { PullRequest } from '../../lib/type'
 import { DISCORD_GITHUB_MAP } from '../../constants/discord'
+import { suggestPRDescriptionAgent } from '../agents/analyze-github-prs'
 
 async function handleMergeConflicts(discordUserId: string, prs: PullRequest[]) {
   const hasMergedConflictsPRs = prs.filter(
@@ -60,6 +61,61 @@ async function handleWaitingForReview(
   }
 }
 
+async function handleSuggestPRDescription(
+  discordUserId: string,
+  prs: PullRequest[],
+) {
+  const embed = {
+    title: `Hey <@${discordUserId}>, your PR needs some improvements`,
+    color: 3447003,
+    fields: [] as { name: string; value: string; inline: boolean }[],
+  }
+  let needSuggestion = false
+  // for each pr, check if it needs suggestion
+  for (const pr of prs) {
+    // use agent to check if PR description is good
+    const prompt = `Based on the following pull request, help me determine if it needs to be improved:
+      ${JSON.stringify({ title: pr.title, body: pr.body }, null, 2)}`
+
+    // call to agent
+    const agentResponse = await suggestPRDescriptionAgent.generate([
+      {
+        role: 'user',
+        content: prompt,
+      },
+    ])
+
+    const agentResponseText = JSON.parse(agentResponse.text) as {
+      suggestion_needed: boolean
+      original_title: string
+      original_body: string
+      suggest_title: string
+      suggest_body: string
+    }
+
+    // create discord embed
+    if (agentResponseText.suggestion_needed) {
+      needSuggestion = true
+      embed.fields.push({
+        name: `#${pr.number} ${pr.title}`,
+        value: `Here are some suggestions for your PR:
+          **Title**: ${agentResponseText.suggest_title}
+          **Description**: ${agentResponseText.suggest_body}`,
+        inline: false,
+      })
+    }
+  }
+
+  // send to discord
+  //if (needSuggestion) {
+  const res = await discordClient.sendMessageToUser({
+    userId: discordUserId,
+    message: '',
+    embed,
+  })
+  //}
+}
+
 const notifyDeveloperAboutPRStatus = new Workflow({
   name: 'Notify developer about PR status',
 })
@@ -87,6 +143,9 @@ const notifyDeveloperAboutPRStatus = new Workflow({
 
               // Notify developer if their PR needs to tag for review
               await handleWaitingForReview(discordUserId, prs)
+
+              // Notify developer, if their PR description needs improvement
+              await handleSuggestPRDescription(discordUserId, prs)
             }
           }),
         )

apps/agent/src/mastra/workflows/github-suggest-prs-description.ts

@@ -1,4 +1,3 @@
 export * from './github-notify-open-prs'
 export * from './github-send-today-list-PRs-to-discord'
 export * from './github-notify-developer-about-pr-status'
-export * from './github-suggest-prs-description'

apps/agent/src/mastra/workflows/index.ts

@@ -38,7 +38,7 @@ export class AskCommand implements Command {
     data: EventData,
   ): Promise<void> {
     // Get the full message content after the command
-    const question = intr.toString().replace('/ask prompt:', '').trim() 
+    const question = intr.toString().replace('/ask prompt:', '').trim()
 
     if (!question) {
       await InteractionUtils.send(
@@ -55,7 +55,10 @@ export class AskCommand implements Command {
         RESPONSE: '...',
         USER: intr.user.id,
       }).addFields([
-        { name: '', value: `**Question**: ${formatQuestionWithUserMention(question)}\n` },
+        {
+          name: '',
+          value: `**Question**: ${formatQuestionWithUserMention(question)}\n`,
+        },
         {
           name: '',
           value: "I'm looking for the answer...",
@@ -66,7 +69,9 @@ export class AskCommand implements Command {
     let response = ''
     try {
       // Process the stream
-      for await (const chunk of getStreamedResponse(`I am <@${intr.user.id}>, ${question}`)) {
+      for await (const chunk of getStreamedResponse(
+        `I am <@${intr.user.id}>, ${question}`,
+      )) {
         response += chunk
       }
 
@@ -210,5 +215,5 @@ async function* getStreamedResponse(
 }
 
 function formatQuestionWithUserMention(question: string): string {
-  return `\` ${question.replace(/(<@?\d+>)/g, '`$1`')} \``;
-}
+  return `\` ${question.replace(/(<@?\d+>)/g, '`$1`')} \``
+}

apps/discord-bot/src/commands/chat/ask-command.ts

@@ -29,7 +29,10 @@ export function replaceDiscordMentions(
   idMap: Record<string, string> = hardCodeIDMap,
 ): string {
   return text.replace(/<@?(\d+)>/g, (match, discordId) => {
-    return "@"+(Object.entries(idMap).find(([_, v]) => v === discordId)?.[0] || match)
+    return (
+      '@' +
+      (Object.entries(idMap).find(([_, v]) => v === discordId)?.[0] || match)
+    )
   })
 }