fix(semconv): declare the SDK's failure_reason key - #117
Merged
Merged
Conversation
Temporal Go SDK 1.49 adds a failure_reason attribute to temporal_activity_execution_failed. The registry did not declare it, so the local-stack conformance row (C22, Weaver live-check) failed with 153 missing_attribute violations, all on that one metric, once order and checkout moved to SDK 1.49. Declare failure_reason as a bare key and reference it from the metric. The value is ActivityError today; the SDK will add more reasons later.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Temporal Go SDK 1.49 (order-service#233, checkout-service#95) adds a
failure_reasonattribute totemporal_activity_execution_failed. Today the value is alwaysActivityError; later SDK releases will add more values.The registry did not declare the key. The release audit's conformance row C22 (Weaver
registry live-check, ADR-076) therefore failed on local-stack with 153 violations. All of them aremissing_attribute: Attribute 'failure_reason' does not exist in the registry, and all are on that one metric.Change
attributes-bare.yaml: declarefailure_reason(string, development, exampleActivityError).metrics-vendor.yaml: reference it frommetric.temporal_activity_execution_failed.Checks
make semconv-check: noafter_resolutionpolicy violation.make semconv-generated-check: the generated Go constants and docs are unchanged.make semconv-lockstep: registry upstream v1.41.0 = obsx semconv v1.41.0.After merge, the G4 release audit reruns from scratch, C22 included.