From bb24cd073b7fb27c1644880a7e98ac53e685c65b Mon Sep 17 00:00:00 2001 From: Duynh ne Date: Fri, 2 Oct 2026 14:06:46 +0700 Subject: [PATCH] fix(semconv): declare the SDK's failure_reason key Temporal Go SDK 1.49 adds a failure_reason attribute to temporal_activity_execution_failed. The registry did not declare it, so the local-stack conformance row (C22, Weaver live-check) failed with 153 missing_attribute violations, all on that one metric, once order and checkout moved to SDK 1.49. Declare failure_reason as a bare key and reference it from the metric. The value is ActivityError today; the SDK will add more reasons later. --- semconv/registry/model/attributes-bare.yaml | 6 ++++++ semconv/registry/model/metrics-vendor.yaml | 1 + 2 files changed, 7 insertions(+) diff --git a/semconv/registry/model/attributes-bare.yaml b/semconv/registry/model/attributes-bare.yaml index 9db2eed..6e4bcde 100644 --- a/semconv/registry/model/attributes-bare.yaml +++ b/semconv/registry/model/attributes-bare.yaml @@ -195,6 +195,12 @@ groups: brief: Examined on log, written by order. examples: - 1 + - id: failure_reason + type: string + stability: development + brief: Why a Temporal activity execution failed, on the SDK's activity failure counter (SDK >= 1.49). + examples: + - ActivityError - id: found type: boolean stability: development diff --git a/semconv/registry/model/metrics-vendor.yaml b/semconv/registry/model/metrics-vendor.yaml index a51d006..b1cc1ad 100644 --- a/semconv/registry/model/metrics-vendor.yaml +++ b/semconv/registry/model/metrics-vendor.yaml @@ -180,6 +180,7 @@ groups: attributes: - ref: activity_type - ref: client_name + - ref: failure_reason - ref: namespace - ref: task_queue - ref: worker_type