Revert "Route task dispatch projections through the history role"

This reverts commit b1df4b1.

Author: rmcdaniel

src/V2/Support/TaskDispatcher.php

@@ -7,7 +7,6 @@
 use Illuminate\Contracts\Bus\Dispatcher as BusDispatcher;
 use Illuminate\Support\Facades\DB;
 use Throwable;
-use Workflow\V2\Contracts\HistoryProjectionRole;
 use Workflow\V2\Enums\TaskStatus;
 use Workflow\V2\Enums\TaskType;
 use Workflow\V2\Exceptions\UnsupportedBackendCapabilitiesException;
@@ -186,20 +185,7 @@ private static function refreshRunSummary(WorkflowTask $task): void
         $run = ConfiguredV2Models::query('run_model', WorkflowRun::class)->find($task->workflow_run_id);
 
         if ($run instanceof WorkflowRun) {
-            self::historyProjectionRole()->projectRun(self::projectionRun($run));
+            RunSummaryProjector::project($run);
         }
     }
-
-    private static function historyProjectionRole(): HistoryProjectionRole
-    {
-        /** @var HistoryProjectionRole $role */
-        $role = app(HistoryProjectionRole::class);
-
-        return $role;
-    }
-
-    private static function projectionRun(WorkflowRun $run): WorkflowRun
-    {
-        return $run->fresh(['instance', 'tasks', 'activityExecutions', 'failures']) ?? $run;
-    }
 }

tests/Feature/V2/V2TaskDispatchTest.php

@@ -14,7 +14,6 @@
 use Tests\TestCase;
 use Workflow\Serializers\Serializer;
 use Workflow\V2\ActivityTaskBridge;
-use Workflow\V2\Contracts\HistoryProjectionRole;
 use Workflow\V2\Enums\ActivityStatus;
 use Workflow\V2\Enums\HistoryEventType;
 use Workflow\V2\Enums\RunStatus;
@@ -33,7 +32,6 @@
 use Workflow\V2\Models\WorkflowRunSummary;
 use Workflow\V2\Models\WorkflowTask;
 use Workflow\V2\Models\WorkflowTimer;
-use Workflow\V2\Support\DefaultHistoryProjectionRole;
 use Workflow\V2\Support\HistoryExport;
 use Workflow\V2\Support\RunDetailView;
 use Workflow\V2\Support\TaskDispatcher;
@@ -92,37 +90,6 @@ public function testTaskDispatchPersistsSuccessOnlyAfterAfterCommitPublicationRu
         $this->assertSame('workflow_task_ready', $summary->liveness_state);
     }
 
-    public function testTaskDispatchUsesHistoryProjectionRoleBindingForSuccessfulDispatches(): void
-    {
-        config()->set('workflows.v2.compatibility.current', 'build-a');
-        config()
-            ->set('workflows.v2.compatibility.supported', ['build-a']);
-
-        $customRole = $this->trackingHistoryProjectionRole();
-
-        $this->app->instance(HistoryProjectionRole::class, $customRole);
-        Queue::fake();
-
-        $run = $this->createWaitingRun('01J00000000000000000000001H');
-
-        /** @var WorkflowTask $task */
-        $task = WorkflowTask::query()->create([
-            'workflow_run_id' => $run->id,
-            'task_type' => TaskType::Workflow->value,
-            'status' => TaskStatus::Ready->value,
-            'available_at' => now()
-                ->subSecond(),
-            'payload' => [],
-            'connection' => 'redis',
-            'queue' => 'default',
-            'compatibility' => 'build-a',
-        ]);
-
-        TaskDispatcher::dispatch($task);
-
-        $this->assertSame([$run->id], $customRole->projectedRunIds);
-    }
-
     public function testTaskDispatchFailureRecordsTransportFailureWithoutPretendingPublishSucceeded(): void
     {
         config()->set('workflows.v2.compatibility.current', 'build-a');
@@ -204,46 +171,6 @@ public function testTaskDispatchFailureRecordsTransportFailureWithoutPretendingP
         $this->assertSame('active', $export['summary']['task_problem_badge']['code']);
     }
 
-    public function testTaskDispatchUsesHistoryProjectionRoleBindingForDispatchFailures(): void
-    {
-        config()->set('workflows.v2.compatibility.current', 'build-a');
-        config()
-            ->set('workflows.v2.compatibility.supported', ['build-a']);
-
-        $customRole = $this->trackingHistoryProjectionRole();
-
-        $this->app->instance(HistoryProjectionRole::class, $customRole);
-        $this->mock(BusDispatcher::class, static function (MockInterface $mock): void {
-            $mock->shouldReceive('dispatch')
-                ->once()
-                ->andThrow(new RuntimeException('Queue transport unavailable.'));
-        });
-
-        $run = $this->createWaitingRun('01J00000000000000000000002H');
-
-        /** @var WorkflowTask $task */
-        $task = WorkflowTask::query()->create([
-            'workflow_run_id' => $run->id,
-            'task_type' => TaskType::Workflow->value,
-            'status' => TaskStatus::Ready->value,
-            'available_at' => now()
-                ->subSeconds(5),
-            'payload' => [],
-            'connection' => 'redis',
-            'queue' => 'default',
-            'compatibility' => 'build-a',
-        ]);
-
-        try {
-            TaskDispatcher::dispatch($task);
-            $this->fail('Expected dispatch to throw.');
-        } catch (RuntimeException $exception) {
-            $this->assertSame('Queue transport unavailable.', $exception->getMessage());
-        }
-
-        $this->assertSame([$run->id], $customRole->projectedRunIds);
-    }
-
     public function testTaskDispatchFailureRecordsUnsupportedQueueCapabilityWithoutRunningInline(): void
     {
         config()->set('queue.default', 'redis');
@@ -979,38 +906,4 @@ private function configureUnsupportedSyncTaskConnection(): void
         config()
             ->set('workflows.v2.compatibility.supported', ['build-a']);
     }
-
-    /**
-     * @return HistoryProjectionRole&object{projectedRunIds:list<string>}
-     */
-    private function trackingHistoryProjectionRole()
-    {
-        return new class(new DefaultHistoryProjectionRole()) implements HistoryProjectionRole {
-            /**
-             * @var list<string>
-             */
-            public array $projectedRunIds = [];
-
-            public function __construct(
-                private readonly DefaultHistoryProjectionRole $delegate,
-            ) {
-            }
-
-            public function projectRun(WorkflowRun $run): WorkflowRunSummary
-            {
-                $this->projectedRunIds[] = $run->id;
-
-                return $this->delegate->projectRun($run);
-            }
-
-            public function recordActivityStarted(
-                WorkflowRun $run,
-                ActivityExecution $execution,
-                ActivityAttempt $attempt,
-                WorkflowTask $task,
-            ): WorkflowRunSummary {
-                return $this->delegate->recordActivityStarted($run, $execution, $attempt, $task);
-            }
-        };
-    }
 }