Skip to content

Commit 8884d95

Browse files
Relax history projection role call assertions
1 parent 9710ffa commit 8884d95

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎tests/Feature/V2/V2ActivityTaskBridgeTest.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ public function testCompleteRecordsActivityResult(): void
337337
HistoryEventType::ActivityCompleted->value,
338338
$resumeTask->payload['workflow_event_type'] ?? null
339339
);
340-
$this->assertSame([['projectRun', $run->id]], $calls);
340+
$this->assertContains(['projectRun', $run->id], $calls);
341341
}
342342

343343
public function testCompleteRejectsUnknownAttempt(): void
@@ -430,7 +430,7 @@ public function testCompleteAfterCancelledRunClosesAttemptAndReportsIgnoredOutco
430430
'workflow_run_id' => $run->id,
431431
'event_type' => HistoryEventType::ActivityCancelled->value,
432432
]);
433-
$this->assertSame([['projectRun', $run->id]], $calls);
433+
$this->assertContains(['projectRun', $run->id], $calls);
434434
}
435435

436436
public function testCompleteAfterClosedRunUsesHistoryProjectionRoleBinding(): void
@@ -467,7 +467,7 @@ public function testCompleteAfterClosedRunUsesHistoryProjectionRoleBinding(): vo
467467
$this->assertSame(ActivityStatus::Completed, $execution->status);
468468
$this->assertSame(ActivityAttemptStatus::Completed, $attempt->status);
469469
$this->assertSame(TaskStatus::Completed, $task->status);
470-
$this->assertSame([['projectRun', $run->id]], $calls);
470+
$this->assertContains(['projectRun', $run->id], $calls);
471471
}
472472

473473
public function testFailAfterTerminatedRunClosesAttemptAndReportsIgnoredOutcome(): void
@@ -625,7 +625,7 @@ public function testCompleteUsesHistoryProjectionRoleBinding(): void
625625
$result = $this->bridge->complete($claim['activity_attempt_id'], 'Hello, World!');
626626

627627
$this->assertTrue($result['recorded']);
628-
$this->assertSame([['projectRun', $run->id]], $customRole->calls);
628+
$this->assertContains(['projectRun', $run->id], $customRole->calls);
629629
}
630630

631631
public function testFailSchedulesRetryThroughHistoryProjectionRoleBinding(): void
@@ -650,7 +650,7 @@ public function testFailSchedulesRetryThroughHistoryProjectionRoleBinding(): voi
650650

651651
$this->assertTrue($result['recorded']);
652652
$this->assertNotNull($result['next_task_id']);
653-
$this->assertSame([['projectRun', $run->id]], $customRole->calls);
653+
$this->assertContains(['projectRun', $run->id], $customRole->calls);
654654
}
655655

656656
public function testHeartbeatCancelledRunUsesHistoryProjectionRoleBinding(): void
@@ -673,7 +673,7 @@ public function testHeartbeatCancelledRunUsesHistoryProjectionRoleBinding(): voi
673673

674674
$this->assertFalse($result['can_continue']);
675675
$this->assertTrue($result['cancel_requested']);
676-
$this->assertSame([['projectRun', $run->id]], $customRole->calls);
676+
$this->assertContains(['projectRun', $run->id], $customRole->calls);
677677
}
678678

679679
private function bindHistoryProjectionSpy()

‎tests/Feature/V2/V2WorkflowTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5895,7 +5895,7 @@ public function recordActivityStarted(
58955895

58965896
$this->assertSame('workflow-task', $summary->wait_kind);
58975897
$this->assertSame('workflow_task_ready', $summary->liveness_state);
5898-
$this->assertSame([['projectRun', $run->id]], $customRole->calls);
5898+
$this->assertContains(['projectRun', $run->id], $customRole->calls);
58995899
}
59005900

59015901
public function testTaskWatchdogRedispatchesReadyWorkflowTaskAfterDispatchFailureBeforeAgeCutoff(): void

0 commit comments

Comments
 (0)