Skip scheduled fires when rollout safety blocks start

Skip scheduled fires when rollout safety blocks start

Treat rejected schedule starts as unavailable executions so schedule evaluation records rollout-safety blockers as skips instead of failures.

Author: rmcdaniel

app/Support/RemoteScheduleStarter.php

@@ -4,6 +4,7 @@
 
 use DateTimeInterface;
 use Workflow\V2\Contracts\ScheduleWorkflowStarter;
+use Workflow\V2\Exceptions\WorkflowExecutionUnavailableException;
 use Workflow\V2\Models\WorkflowSchedule;
 use Workflow\V2\Support\ScheduleStartResult;
 
@@ -45,6 +46,29 @@ public function start(
         ], static fn (mixed $v): bool => $v !== null);
 
         $result = $this->startService->start($payload, $schedule->namespace);
+        $started = is_bool($result['started'] ?? null)
+            ? $result['started']
+            : ($result['reason'] ?? null) === null;
+
+        if (! $started) {
+            $blockedReason = is_string($result['reason'] ?? null) && trim($result['reason']) !== ''
+                ? trim($result['reason'])
+                : 'start_rejected';
+            $message = is_string($result['message'] ?? null) && trim($result['message']) !== ''
+                ? trim($result['message'])
+                : sprintf(
+                    'Schedule [%s] could not start workflow type [%s].',
+                    $schedule->schedule_id,
+                    $action['workflow_type'] ?? 'unknown',
+                );
+
+            throw new WorkflowExecutionUnavailableException(
+                'schedule_start',
+                $schedule->schedule_id,
+                $blockedReason,
+                $message,
+            );
+        }
 
         return new ScheduleStartResult(
             instanceId: (string) $result['workflow_id'],

tests/Feature/ScheduleEvaluateTest.php

@@ -5,9 +5,9 @@
 use App\Models\WorkflowNamespace;
 use App\Support\WorkflowStartService;
 use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\DB;
 use Mockery\MockInterface;
 use Tests\TestCase;
-use Workflow\V2\Contracts\WorkflowControlPlane;
 use Workflow\V2\Models\WorkflowInstance;
 use Workflow\V2\Models\WorkflowRun;
 use Workflow\V2\Models\WorkflowSchedule;
@@ -188,6 +188,41 @@ public function test_it_records_failures_and_returns_exit_code_1(): void
         $this->assertStringContainsString('Workflow type not found', $lastAction['reason']);
     }
 
+    public function test_it_records_rollout_safety_start_rejections_as_skips(): void
+    {
+        $this->fakeStartService(result: [
+            'started' => false,
+            'workflow_id' => 'wf-skip-compatibility-blocked',
+            'run_id' => null,
+            'workflow_type' => 'TestWorkflow',
+            'outcome' => 'rejected_compatibility_blocked',
+            'reason' => 'compatibility_blocked',
+            'rejection_reason' => 'compatibility_blocked',
+            'message' => 'Workflow instance [wf-skip-compatibility-blocked] cannot start.',
+        ]);
+
+        WorkflowSchedule::create([
+            'schedule_id' => 'skip-compatibility-blocked',
+            'namespace' => 'default',
+            'spec' => ['cron_expressions' => ['* * * * *']],
+            'action' => ['workflow_type' => 'TestWorkflow'],
+            'next_fire_at' => now()->subMinute(),
+        ]);
+
+        $this->artisan('schedule:evaluate')
+            ->assertExitCode(0)
+            ->expectsOutputToContain('skipped');
+
+        $schedule = WorkflowSchedule::where('schedule_id', 'skip-compatibility-blocked')->firstOrFail();
+        $this->assertSame('compatibility_blocked', $schedule->last_skip_reason);
+        $this->assertSame(1, (int) $schedule->skipped_trigger_count);
+        $this->assertSame(0, (int) $schedule->fires_count);
+        $this->assertSame(0, (int) $schedule->failures_count);
+        $this->assertNull($schedule->last_fired_at);
+        $this->assertNull($schedule->latest_workflow_instance_id);
+        $this->assertSame([], $schedule->recent_actions ?? []);
+    }
+
     // ── next_fire_at advancement ────────────────────────────────────
 
     public function test_it_advances_next_fire_at_after_successful_fire(): void
@@ -552,7 +587,7 @@ public function test_it_normalizes_legacy_timeout_fields_when_firing(): void
         ]);
 
         // Bypass the model accessor to write raw legacy JSON
-        \Illuminate\Support\Facades\DB::table('workflow_schedules')
+        DB::table('workflow_schedules')
             ->where('id', $schedule->id)
             ->update(['action' => json_encode([
                 'workflow_type' => 'TestWorkflow',
@@ -605,7 +640,7 @@ public function test_it_normalizes_legacy_timeout_fields_when_draining_buffer():
         ]);
 
         // Write raw legacy JSON directly
-        \Illuminate\Support\Facades\DB::table('workflow_schedules')
+        DB::table('workflow_schedules')
             ->where('id', $schedule->id)
             ->update(['action' => json_encode([
                 'workflow_type' => 'TestWorkflow',