StellarMonitorService, the core confirmation cron job, has no spec

[martinzhames]

Category: testing

Problem

src/stellar/stellar-monitor.service.ts has no matching .spec.ts anywhere in the repo, despite being the service that scans Stellar Horizon transactions, confirms payments, expires stale payments, and triggers settlement.

Impact

With zero unit tests, the two runtime bugs filed separately (unreachable pollEscrowEvents call, call to nonexistent pollTransferEvents) went completely undetected — this is the single highest-value module in the codebase to leave untested.

Suggested fix

Add src/stellar/stellar-monitor.service.spec.ts covering scanPendingPayments, confirmPayment, and expireOldPayments with mocked Stellar/Soroban dependencies.

[akinerin]

@akinerin has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Please assign me this task

ℹ️ Repo Maintainers: To accept this application, review their application or assign @akinerin to this issue.

[starkiVector-090]

@starkiVector-090 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi team, I would love to work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @starkiVector-090 to this issue.

[drips-wave]

Congratulations, @starkiVector-090! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @starkiVector-090: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊