getLastRunStatus has unreachable code — escrow poll never runs

[martinzhames]

Category: bug

Problem

src/stellar/stellar-monitor.service.ts around lines 120-132 has return { lastRunAt, status, lastError }; immediately followed by await this.sorobanMonitor.pollEscrowEvents(); — the await sits after the return statement, making it dead/unreachable code.

Impact

pollEscrowEvents() (a real, useful method on SorobanMonitorService that verifies deposit balances and marks escrow deposit/release/refund/expired/dispute state transitions) is never invoked anywhere in the app as a result of this apparent copy-paste/merge error, so on-chain escrow state is never reconciled against the database.

Suggested fix

Move the pollEscrowEvents() call before the return, or into the appropriate scanning method rather than the status-reporting getter it currently sits in.

[pleasureiliya69-ops]

@pleasureiliya69-ops has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi Maintainer, reviewed the issue in detail. Full stack background with solid experience relevant to this task. No blockers on my end — I'm ready to submit a PR shortly. Please assign.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @pleasureiliya69-ops to this issue.

[starkiVector-090]

@starkiVector-090 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi team, I would love to work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @starkiVector-090 to this issue.

[collins-uzu]

@collins-uzu has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi, I'd like to work on this issue.

I've gone through the requirements, understand the problem, and have the skills needed to implement a solution.

Could you please assign it to me?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @collins-uzu to this issue.

[drips-wave]

Congratulations, @starkiVector-090! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @starkiVector-090: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊