soroban-expiry.service.spec.ts tests an implementation that no longer exists

[martinzhames]

Category: testing

Problem

src/blockchain-wallet/soroban-expiry.service.spec.ts exercises setCurrentLedger, createPayment, confirm, getPayment, expirePayment, isExpired, advanceLedger, getExpiredEventLog, and static LEDGERS_PER_MINUTE/DEFAULT_EXPIRY_LEDGERS on SorobanService — none of which exist on the current class in src/blockchain-wallet/soroban.service.ts (which only has pause/unpause/deposit/release/refund/registerUser/getBalance/getStakeBalance).

Impact

This entire spec file (the ledger-based-expiry contract-mirroring test suite, ~17 tests) is orphaned and cannot pass — it appears to target an implementation that was reverted or overwritten, and pnpm test presumably fails or the file is silently excluded, either way masking a real regression.

Suggested fix

Reconcile with the SorobanService duplicate-export issue above; once one true implementation is settled on, update or delete this spec to match it.

[damiedee96]

@damiedee96 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello Maintainer, I'd love to work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @damiedee96 to this issue.

[akinerin]

@akinerin has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Please assign me this task

ℹ️ Repo Maintainers: To accept this application, review their application or assign @akinerin to this issue.

[lyon-1050]

@lyon-1050 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello team, can I work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @lyon-1050 to this issue.

[drips-wave]

Congratulations, @lyon-1050! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @lyon-1050: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊