Skip to content

Commit 9de5769

Browse files
committed
Update warnings
1 parent d1bebdb commit 9de5769

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/option_parser.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,13 @@ int string_parse_list(const void *data, const char *s, void *ret) {
131131
switch (type) {
132132
case MOUSE_LIST:
133133
arr = string_to_array(s, ",");
134-
success = string_parse_enum_list(&mouse_action_enum_data,
135-
arr, ret);
134+
success = string_parse_enum_list(&mouse_action_enum_data, arr, ret);
136135
break;
137136
case OFFSET_LIST:
138137
arr = string_to_array(s, "x");
139138
int len = string_array_length(arr);
140139
if (len != 2) {
141140
success = false;
142-
//LOG_W("Offset has two values, separated by an 'x'");
143141
break;
144142
}
145143
int *int_arr = NULL;
@@ -311,7 +309,7 @@ int string_parse_length(void *ret_in, const char *s) {
311309
int val = 0;
312310
bool success = safe_string_to_int(&val, s);
313311
if (!success) {
314-
LOG_W("Specify either a single value or a two values between brackets");
312+
LOG_W("Specify either a single value or two comma-separated values between parentheses");
315313
return false;
316314
}
317315

@@ -326,7 +324,7 @@ int string_parse_length(void *ret_in, const char *s) {
326324
int len = string_array_length(s_arr);
327325
if (len != 2) {
328326
g_strfreev(s_arr);
329-
LOG_W("Specify either a single value or a two values between brackets");
327+
LOG_W("Specify either a single value or two comma-separated values between parentheses");
330328
return false;
331329
}
332330

@@ -404,7 +402,7 @@ bool set_from_string(void *target, struct setting setting, const char *value) {
404402
case TYPE_LENGTH:
405403
// Keep compatibility with old offset syntax
406404
if (STR_EQ(setting.name, "offset") && string_parse_list(GINT_TO_POINTER(OFFSET_LIST), value, target)) {
407-
LOG_I("Using legacy offset syntax nxn, you could use length syntax (n,n)");
405+
LOG_I("Using legacy offset syntax NxN, you should switch to the new syntax (N, N)");
408406
return true;
409407
}
410408
return string_parse_length(target, value);

0 commit comments

Comments
 (0)