Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vulnerabilities in used old dependencies: inquirer & lodash #355

Open
ale4ko69 opened this issue Aug 26, 2021 · 10 comments
Open

New vulnerabilities in used old dependencies: inquirer & lodash #355

ale4ko69 opened this issue Aug 26, 2021 · 10 comments

Comments

@ale4ko69
Copy link

npm audit

lodash <=4.17.20
Severity: high
Prototype Pollution - https://npmjs.com/advisories/1065
Prototype Pollution - https://npmjs.com/advisories/1523
Command Injection - https://npmjs.com/advisories/1673
Prototype Pollution - https://npmjs.com/advisories/577
Prototype Pollution - https://npmjs.com/advisories/782
No fix available
node_modules/vorpal/node_modules/inquirer/node_modules/lodash
inquirer <=0.11.4
Depends on vulnerable versions of lodash
node_modules/vorpal/node_modules/inquirer
vorpal *
Depends on vulnerable versions of inquirer
node_modules/vorpal

@TorahG
Copy link

TorahG commented Sep 1, 2021

Also running into this. I initially thought the issue was with Inquirer, but it appears they do not have lodash listed as a dependency, so perhaps Vorpal needs to upgrage lodash. Here is a screenshot of the audit output from npm.
Screen Shot 2021-09-01 at 11 16 31 AM

@macrozone
Copy link

anyone know a maintained fork of vorpal or something similar?

@robross0606
Copy link

robross0606 commented Aug 30, 2022

This is really disappointing. There are currently 17 open pull requests so clearly people are trying to help maintain this. But the project owner appears to have somewhat abandoned it. He even suggests someone "shoot him a note" to help maintain it, but there have been no updates in years. If anyone knows of a maintained fork that is actually published to npm with a unique name, please post.

@sabbaticaldev
Copy link

If you wanna help just fork it yourself in place of expecting someone that moved on to work on it again, no?

@robross0606
Copy link

robross0606 commented Jun 19, 2024

@sabbaticaldev, with respect, forking doesn't help the community. All it does is fragment things. If they have "moved on", the owner(s) of this repository should ask for contributors on this repository and work to transition it. Even if I fork the project, I cannot simply publish new versions of this artifact. I'd have to create a different name and then we just add community confusion.

@RheaSidana
Copy link

"dependencies": {
"lodash": "^4.17.21",
},
"overrides": {
"lodash": "$lodash",
}

Add dependencies explicitly and overrides them, in the package.json file

@sabbaticaldev
Copy link

@robross0606 there is no fragmenting if the original work stopped like the case here. There is just complaining and laziness.

@robross0606
Copy link

robross0606 commented Sep 1, 2024

@sabbaticaldev The vitriol is unnecessary. It costs nothing to be nice. I respectfully disagree and the already existent forks of this project back it up. This project is also not properly marked as archived. While I'm at it, why not spend an ounce of that wasted hate and spin up your own fork? More fun to troll people instead? If you have nothing useful to contribute, get off the thread.

@sabbaticaldev
Copy link

sabbaticaldev commented Sep 1, 2024

It costs nothing for you to be nice too, @robross0606. Let me remind you that you started this with your condescending tone "This is really disappointing". You are not entitled to free work from free software, you know? In place of wasting so much of our energy with this useless discussion you could have done it the right way.

Also a reminder to you that this here is real life. People get sick, people die, people change priorities in their life.

@robross0606
Copy link

robross0606 commented Sep 1, 2024

How is "disappointing" condescending? Seriously? Disappointing is a feeling I have. I'm not telling you you're anything (like lazy) and nothing was sarcastic or spoken as if to a child. I'm saying I'm disappointed that this repo hasn't handled shutdown properly:

  • It hasn't handed off to another maintainer.
  • It hasn't posted an updated notice in README as to maintenance status.
  • It hasn't archived on GitHub.
  • It hasn't accepted outstanding merge requests.

That's disappointing to me. There's nothing condescending there and nothing hurtful. Sorry, I don't know why you got feelings hurt by that, but you may want to look up the definition of "condescending". (Hint: That last sentence was condescending.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants