Circuit: adjust SetActiveElement to behave closer to the upstream version.

Author: PMeira

docs/changelog.md

@@ -20,6 +20,7 @@
 ## Version 0.14.3 (next, unreleased)
 
 - API/YMatrix: check for valid circuit in a few more functions.
+- API/Circuit: adjust `SetActiveElement` to be more conformant with the official version, i.e., returns -1 for non-circuit elements.
 
 ## Version 0.14.2 (2024-02-26)
 

src/Common/Circuit.pas

@@ -2015,7 +2015,7 @@ function TDSSCircuit.SetElementActive(const FullObjectName: String): Integer;
     DevType,
     DevName: String;
     DevCls: TDSSClass;
-    element: TDSSCktElement;
+    element: TDSSObject;
 begin
     Result := 0;
     ParseObjectClassandName(DSS, FullObjectName, DevType, DevName);
@@ -2029,12 +2029,12 @@ function TDSSCircuit.SetElementActive(const FullObjectName: String): Integer;
 
     if not DuplicatesAllowed then
     begin
-        element := TDSSCktElement(DevCls.Find(DevName, FALSE));
-        if element <> NIL then
+        element := DevCls.Find(DevName, FALSE);
+        if (element <> NIL) and (element is TDSSCktElement) then
         begin
             DSS.ActiveDSSClass := DSS.DSSClassList.Get(DevClassIndex);
             DSS.LastClassReferenced := DevClassIndex;
-            Result := element.Handle;
+            Result := TDSSCktElement(element).Handle;
             ActiveCktElement := CktElements.Get(Result);
         end;
     end