Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dss-python dependency #112

Closed
4 tasks done
charraig opened this issue Mar 22, 2022 · 8 comments · Fixed by #110
Closed
4 tasks done

Update dss-python dependency #112

charraig opened this issue Mar 22, 2022 · 8 comments · Fixed by #110

Comments

@charraig
Copy link

Versions

  • Python version: 3.9.10
  • Python architecture: x64
  • Operating system and version: Mac Monterey 12.0.1 M1 Chip
  • OpenDSSDirect.py version number: 0.6.1

Feature Request

dss-python just released version 0.12.0b2 to support the Mac M1 ARM chips, but setup.py includes enforcement for version 0.10.7.post1. Could you modify this dependency requirement to be "^0.10" so that dependency managers (e.g. poetry) allow for the 0.12 version?

@charraig
Copy link
Author

I see there is already a PR. +1 for merge! #110

@PMeira
Copy link
Member

PMeira commented Mar 23, 2022

@charraig For engine updates, usually we merge just before the release. This next version (based on DSS C-API 0.12) is special since a lot of things were changed in the engine internals, hence the extended test period. It seems good though, so it shouldn't take much longer.

About M1/ARM64, I'm not able to test it, so please let us know if you find any breaking issue. If you're able to run ODD.py's updated tests from the PR branch https://github.com/dss-extensions/OpenDSSDirect.py/tree/dss_python-0.12.0, it should be OK.

@charraig
Copy link
Author

Hi @PMeira, thanks for the help! I was finally able to give this a test, found an import issue, I put a comment over at: dss-extensions/DSS-Python#41 (comment)

@charraig
Copy link
Author

@PMeira I also tested the 0.12.0.b4 dss-python version from here, all 59 tests passed once I moved the import statement of test_evaluate_expression.py into the function itself. Not sure if that's the proper fix, but I was getting a "module not found" error when it was outside the function.

@charraig charraig reopened this Apr 13, 2022
@PMeira
Copy link
Member

PMeira commented Apr 14, 2022

@charraig That's great news!
I added a commit to move the import per your comment. Kind of weird that it doesn't happen in the CI etc., but that doesn't affect much (that file doesn't use the DSS engine, and might be removed sooner or later after the new API changes land).

@qhuang0411
Copy link

I have almost the same setup as @charraig, and my dependency manager poetry failed to install opendssDirect.py=0.6.1 due to "Unable to find installation candidates for dss-python (0.10.7.post1)", any suggestion to address this?

@charraig
Copy link
Author

charraig commented May 23, 2022

Hi @qhuang0411, I put this line in my poetry package toml file to call the specific branch that has the working update:

'OpenDSSDirect.py' = { git = "https://github.com/dss-extensions/OpenDSSDirect.py.git", branch = "dss_python-0.12.0"}

See if that works for you.

@PMeira
Copy link
Member

PMeira commented Jul 16, 2022

@charraig @qhuang0411 New packages released on PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants