Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem packaged files don't match README #129

Open
kbroderick opened this issue Jan 10, 2019 · 4 comments
Open

Gem packaged files don't match README #129

kbroderick opened this issue Jan 10, 2019 · 4 comments

Comments

@kbroderick
Copy link

The current gem on rubygems (0.8.0) doesn't seem to match the README or code here (the version on the engine here is at 0.7.0, and the require statement given (jquery.gridster) doesn't match the packaged file (jquery.dsmorse-gridster).

I'm happy to submit a pull request to update the README if that's all that's required, but it seems like something is out of sync between this repo and the rubygems file.

@fixmycode
Copy link

I don't know who's managing releases on rubygems, but I'll look into it and get back to you.

@fixmycode
Copy link

It appears that @dsmorse updated the rubygems release and it was my job to update the readme files, and I didn't do it (I.. forgot to). I'm not really available to do it right now so i'd really appreciate if you submit the request and we set everything on date. I'll update npm too as soon as I can.

@kbroderick
Copy link
Author

I'll create a pull request to update the README, but I'm noticing two other issues:

  1. the files in the dist directory don't match the current output created from grunt (they're of the jquery.gridster... format when current output is jquery.dsmorse-gridster... based on the package name in package.json); running grunt clean and then grunt solves this, but I'm not sure if the dist directory should be excluded from the repo given that it's generated code, or just updated (happy to create a pull request for either, just let me know). Building the gem without calling grunt clean first results in the older filenames.

  2. package.json is still showing 0.7.0. That should be bumped to 0.8.0, correct?

@fixmycode
Copy link

  1. yes, go ahead and
  2. yes.

leithhobson added a commit that referenced this issue May 28, 2019
Address #129 -- README instructions for Gemfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants