feat(google-analytics): add gatsby-plugin-google-analytics #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travi
reviewed
Oct 26, 2019
| options: { | ||
| trackingId: 'GOOGLE_ANALYTICS_TRACKING_ID', | ||
| head: true, | ||
| cookieDomain: 'dsmjs.com' |
There was a problem hiding this comment.
since we will need to move this site from the current domain to the actual dsmjs.com domain once the site is operational, i've been hesitant to do this before we get things migrated. i wouldnt mind having confidence that its ready to go though.
since i havent configured a new site for GA for a while, do you know off the top of your head if transitioning domains is well supported or if it would be better to wait?
There was a problem hiding this comment.
Will it hurt to have this config there as a placeholder, then use an actual tracking ID/set it up on Google Analytics website once this goes live on dsmjs.com?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs the actual Google Analytics tracking ID added and any other options set that are required.
This will resolve #12.