Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

type 'a key should be string instead of Bytes.t #13

Closed
vbmithr opened this issue Dec 22, 2014 · 2 comments
Closed

type 'a key should be string instead of Bytes.t #13

vbmithr opened this issue Dec 22, 2014 · 2 comments

Comments

@vbmithr
Copy link
Contributor

vbmithr commented Dec 22, 2014

Internally, the type 'a key in several modules should probably by string instead of Bytes.t, because keys are supposed to be immutable and only exported/imported from storage (if I understand well).

@whitequark
Copy link
Contributor

That would require either unsafe operations everywhere or copying, neither of which really improves anything.

@vbmithr
Copy link
Contributor Author

vbmithr commented Dec 7, 2016

Superseeded by #40.

@vbmithr vbmithr closed this as completed Dec 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants