Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video rotation is not handled #120

Open
KostyaSha opened this issue Aug 4, 2023 · 1 comment
Open

Video rotation is not handled #120

KostyaSha opened this issue Aug 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@KostyaSha
Copy link

Just in case somebody already solved and can share while i'm debugging this thing.
When ios runs it has 0' orientation in portrait mode, as soon as it runs landscape app image in browser is rotated and looks correct, but clicks are messed. Also ui doesn't highlight landscape mode and info->orientation is not changed. That happens because of missing device.change -> rotation event. As soon as it added rotate button highlights and work fine, but image is double rotated and still miss-clicked. I guess there is nuance on how at all images should be streamed into browser with websocket. avfoundation changes width and height according to layout, i guess android send always the same size, but with the note of rotation.
As experiment i enforced ivf_pull to produce sticky image layout (rotated with 270' when width > height and swapped width-height values). But clicks are still 90' degree wrong.

I also don't see any updates from backend into UI about scale.
@nanoscopic do you remember in what state did you end this part? Did it work ever? What is clickscale? Maybe you can share some knowledge on how STF web processes this part?

@nanoscopic
Copy link
Collaborator

This was not coded to be handled. It is TODO.

Handling for it needs to be written in.

Clickscale, to my memory, is the scaling of coordinates for clicking, versus the scale to turn the raw video into coordinates for on screen display. I agree "clickscale" is really confusing.

@nanoscopic nanoscopic changed the title broken clicks on landscape layout Video rotation is not handled Aug 11, 2023
@nanoscopic nanoscopic added the enhancement New feature or request label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants