Skip to content

Gradle 8.10 breaks AffectedModuleDetector dependentList tracking #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcumings opened this issue Aug 21, 2024 · 2 comments
Closed

Gradle 8.10 breaks AffectedModuleDetector dependentList tracking #260

mcumings opened this issue Aug 21, 2024 · 2 comments

Comments

@mcumings
Copy link

DependencyTracker.dependentList is a Map<Project, Set<Project>>. This operates under the assumption that the Project equals/hashcode implementations uniquely identifies a single project instance.

In Gradle 8.10 it appears as though this assumption is now invalid, resulting in the same project (by path) being added as multiple keys in the dependentList map. This then breaks subsequent findAllDependents lookups, resulting in the incorrect result that no modules are affected by a change.

@bddckr
Copy link

bddckr commented Aug 22, 2024

An issue was opened with Gradle: gradle/gradle#30272

Work's already ongoing to work around that Gradle change: #257

@joshafeinberg
Copy link
Member

Yes, should be fixed with #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants