Skip to content

Commit cb5ffd1

Browse files
authored
Merge pull request #118 from dpryan79/fix117
Fix #117, bump version to 0.5.3
2 parents 8d1a77e + 57fb9b4 commit cb5ffd1

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
Version 0.5.3:
2+
3+
* Fixed an issue with the `perRead` subcommand, wherein the requireFlags option didn't fully work (a read would pass if it had at least one of the required flags set, rather than all of them). (issue #117)
4+
15
Version 0.5.2:
26

37
* Rewrote how read-pair overlap handling is performed. It now uses the constructor/destructor mechanism from htslib instead of using internal htslib structures and functions. This allows supporting newer htslib versions. Currently 1.11 is the only tested and working version, due to changes in the pileup constructor interface in it. (issue #99)

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ CFLAGS ?= -Wall -g -O3 -pthread
1111
all: MethylDackel
1212

1313
OBJS = common.o bed.o svg.o overlaps.o extract.o MBias.o mergeContext.o perRead.o
14-
VERSION = 0.5.2
14+
VERSION = 0.5.3
1515

1616
version.h:
1717
echo '#define VERSION "$(VERSION)"' > $@

azure-pipeline.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@ jobs:
4141
displayName: Add conda to PATH
4242
- bash: sudo chown -R 501:20 /usr/local/miniconda/pkgs
4343
displayName: Fix permissions
44-
- bash: conda create -n MethylDackel -q --yes -c conda-forge -c bioconda htslib=$(HTSLIB_VERSION) python clang clang_osx-64 clangxx cctools compiler-rt ld64 libbigwig
44+
- bash: conda create -n MethylDackel -q --yes -c conda-forge -c bioconda htslib=$(HTSLIB_VERSION) python clang=11.1.0 clang-11 clang_osx-64=11.1.0 clangxx=11.1.0 cctools_osx-64 compiler-rt ld64_osx-64 libcxx make libbigwig
4545
displayName: Installing dependencies
4646
- template: .azure-pipelines/test-template.yml

perRead.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ void *perReadMetrics(void *foo) {
188188
if(b->core.pos < localPos) continue;
189189
if(b->core.pos >= localEnd) break;
190190
nmethyl = 0, nunmethyl = 0;
191-
if(config->requireFlags && (config->requireFlags & b->core.flag) == 0) continue;
191+
if(config->requireFlags && (config->requireFlags & b->core.flag) != config->requireFlags) continue;
192192
if(config->ignoreFlags && (config->ignoreFlags & b->core.flag) != 0) continue;
193193
if(b->core.qual < config->minMapq) continue;
194194
processRead(config, b, seq, localPos2, seqlen, &nmethyl, &nunmethyl);

0 commit comments

Comments
 (0)