-
Notifications
You must be signed in to change notification settings - Fork 593
Make it possible to pass a logits processor to Generator
#1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've also run into situations in which it would be convenient to be able to do that. I see no problems with it apart from risking to make the interface harder to understand for users. For the implementation, I think it would make sense to keep only the User entry point1. The user passes their logits processor directly to Pros:
Cons:
2. Create a separate function Pros:
Cons:
3. Make users directly interact with the Pros:
Cons:
Implementation in
|
We could have users pass the logits processor as a keyword-only As for the implementation, I like the classmethod solution. |
See for instance #1408, but also for internal testing. This is an important design decisions, we need to consider pros & cons of each possible choice.
The text was updated successfully, but these errors were encountered: